Add --disable-panels for blocking all extensions from using panels.

Add --disable-panels for blocking all extensions from using panels.

BUG=467808
TBR=isherman@chromium.org

Committed: https://crrev.com/f738fce08cff27c75b238ce239685dc7a5a2c185
Cr-Commit-Position: refs/heads/master@{#366517}

[Evan Stade, 2015-12-21 23:37:32]

estade@chromium.org changed reviewers:
+ dimich@chromium.org, stevenjb@chromium.org

[dcheng, 2015-12-21 23:44:22]

dcheng@chromium.org changed reviewers:
+ dcheng@chromium.org

[dcheng, 2015-12-21 23:44:23]

How does this mesh with https://codereview.chromium.org/1516253002/, which adds
another extension to the whitelist?

https://codereview.chromium.org/1541033002/diff/1/chrome/browser/about_flags.cc
File chrome/browser/about_flags.cc (left):

https://codereview.chromium.org/1541033002/diff/1/chrome/browser/about_flags....
chrome/browser/about_flags.cc:530: {"ignore-gpu-blacklist",
I know there's been a lot of debate whether or not to clang-format this file.

Maybe just leave it unformatted for now to minimize the diff?

[Evan Stade, 2015-12-21 23:50:15]

On 2015/12/21 23:44:23, dcheng wrote:
> How does this mesh with https://codereview.chromium.org/1516253002/, which
adds
> another extension to the whitelist?

The goal of this change is to make it possible to test how whitelisted
extensions behave without panel support (i.e. when falling back to popup type
windows). These two patches should be able to coexist for now. Panels aren't
going anywhere on CrOS (AFAIU) so it's probably ok to keep building the IME
extension on them, as long as it's CrOS-only.

https://codereview.chromium.org/1541033002/diff/1/chrome/browser/about_flags.cc
File chrome/browser/about_flags.cc (left):

https://codereview.chromium.org/1541033002/diff/1/chrome/browser/about_flags....
chrome/browser/about_flags.cc:530: {"ignore-gpu-blacklist",
On 2015/12/21 23:44:23, dcheng wrote:
> I know there's been a lot of debate whether or not to clang-format this file.
> 
> Maybe just leave it unformatted for now to minimize the diff?

oops..

[Dmitry Titov, 2015-12-22 00:06:51]

LGTM

Indeed, IME extension is ChromeOS-only, and Panels are going to remain on
ChromeOS for a long time.

[stevenjb, 2015-12-22 00:39:06]

lgtm

[Evan Stade, 2015-12-22 00:43:45]

Description was changed from

==========
Add --disable-panels for blocking all extensions from using panels.

BUG=467808
==========

to

==========
Add --disable-panels for blocking all extensions from using panels.

BUG=467808
TBR=isherman@chromium.org
==========

[Evan Stade, 2015-12-22 00:43:45]

estade@chromium.org changed reviewers:
+ isherman@chromium.org

[Evan Stade, 2015-12-22 00:43:54]

TBR isherman for histograms.xml

[Evan Stade, 2015-12-22 00:43:58]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2015-12-22 00:43:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org, dimich@chromium.org
Link to the patchset: https://codereview.chromium.org/1541033002/#ps40001
(title: "update histograms.xml")

[commit-bot: I haz the power, 2015-12-22 00:44:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1541033002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1541033002/40001

[Ilya Sherman, 2015-12-22 01:07:47]

histograms.xml lgtm

[commit-bot: I haz the power, 2015-12-22 02:04:33]

Description was changed from

==========
Add --disable-panels for blocking all extensions from using panels.

BUG=467808
TBR=isherman@chromium.org
==========

to

==========
Add --disable-panels for blocking all extensions from using panels.

BUG=467808
TBR=isherman@chromium.org
==========

[commit-bot: I haz the power, 2015-12-22 02:04:34]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-22 02:05:22]

Description was changed from

==========
Add --disable-panels for blocking all extensions from using panels.

BUG=467808
TBR=isherman@chromium.org
==========

to

==========
Add --disable-panels for blocking all extensions from using panels.

BUG=467808
TBR=isherman@chromium.org

Committed: https://crrev.com/f738fce08cff27c75b238ce239685dc7a5a2c185
Cr-Commit-Position: refs/heads/master@{#366517}
==========

[commit-bot: I haz the power, 2015-12-22 02:05:23]

Patchset 3 (id:??) landed as
https://crrev.com/f738fce08cff27c75b238ce239685dc7a5a2c185
Cr-Commit-Position: refs/heads/master@{#366517}