Keep original pushState() method for use in JS overwrite

Keep original pushState() method for use in JS overwrite

Keep original pushState() method for use in JS overwrite of
window.history.pushState. Previously, the original replaceState was
used because back/forward navigation was performed wholly by the native
history stack. Using the original pushState keeps WKWebView's
back forward list in sync with the native stack.

BUG=564633
Committed: https://crrev.com/66238f7e788dfff4a656c7a34089bf0a499220c9
Cr-Commit-Position: refs/heads/master@{#367378}

[Jackie Quinn, 2015-12-21 23:37:51]

jyquinn@chromium.org changed reviewers:
+ marq@chromium.org

[Jackie Quinn, 2016-01-04 20:37:18]

jyquinn@chromium.org changed reviewers:
+ eugenebut@chromium.org
- marq@chromium.org

[Eugene But (OOO till 7-30), 2016-01-04 20:52:31]

lgtm

https://codereview.chromium.org/1541023002/diff/1/ios/web/web_state/js/resour...
File ios/web/web_state/js/resources/core.js (right):

https://codereview.chromium.org/1541023002/diff/1/ios/web/web_state/js/resour...
ios/web/web_state/js/resources/core.js:405:
originalWindowHistoryPushState.call(history, stateObject, '', pageUrl);
I think you want to pass pageTitle as well, otherwise WKWebView's title may be
incorrect. Same is probably true for |replaceState|.

[Jackie Quinn, 2016-01-04 21:16:59]

https://codereview.chromium.org/1541023002/diff/1/ios/web/web_state/js/resour...
File ios/web/web_state/js/resources/core.js (right):

https://codereview.chromium.org/1541023002/diff/1/ios/web/web_state/js/resour...
ios/web/web_state/js/resources/core.js:405:
originalWindowHistoryPushState.call(history, stateObject, '', pageUrl);
On 2016/01/04 20:52:30, eugenebut wrote:
> I think you want to pass pageTitle as well, otherwise WKWebView's title may be
> incorrect. Same is probably true for |replaceState|.

Done.

[Jackie Quinn, 2016-01-04 21:17:41]

The CQ bit was checked by jyquinn@chromium.org

[Jackie Quinn, 2016-01-04 21:17:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/1541023002/#ps20001
(title: "Use pageTitle")

[commit-bot: I haz the power, 2016-01-04 21:18:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1541023002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1541023002/20001

[commit-bot: I haz the power, 2016-01-04 21:43:35]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-04 21:44:33]

Description was changed from

==========
Keep original pushState() method for use in JS overwrite

Keep original pushState() method for use in JS overwrite of
window.history.pushState. Previously, the original replaceState was
used because back/forward navigation was performed wholly by the native
history stack. Using the original pushState keeps WKWebView's
back forward list in sync with the native stack.

BUG=564633
==========

to

==========
Keep original pushState() method for use in JS overwrite

Keep original pushState() method for use in JS overwrite of
window.history.pushState. Previously, the original replaceState was
used because back/forward navigation was performed wholly by the native
history stack. Using the original pushState keeps WKWebView's
back forward list in sync with the native stack.

BUG=564633

Committed: https://crrev.com/66238f7e788dfff4a656c7a34089bf0a499220c9
Cr-Commit-Position: refs/heads/master@{#367378}
==========

[commit-bot: I haz the power, 2016-01-04 21:44:34]

Patchset 2 (id:??) landed as
https://crrev.com/66238f7e788dfff4a656c7a34089bf0a499220c9
Cr-Commit-Position: refs/heads/master@{#367378}