Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 1540993004: Revert "Cleanup: Remove unused CFX_PSRenderer and various encoders it used." (Closed)

Created:
5 years ago by Lei Zhang
Modified:
5 years ago
Reviewers:
Oliver Chang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Cleanup: Remove unused CFX_PSRenderer and various encoders it used." This reverts commit 2d63eaaa39bb3d402c658b2a6e0eae50a30f1d89. Broke the Windows build, though it is likely the code is unused on Windows too. Committed: https://pdfium.googlesource.com/pdfium/+/be9095d0b2819cdc88785b0b4fdfccf837eb96a9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1665 lines, -182 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M core/include/fpdfapi/fpdf_parser.h View 1 chunk +11 lines, -12 lines 0 comments Download
M core/include/fxcodec/fx_codec.h View 6 chunks +47 lines, -16 lines 0 comments Download
M core/include/fxge/fx_ge.h View 1 chunk +119 lines, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp View 8 chunks +39 lines, -56 lines 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_image.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp View 1 chunk +19 lines, -16 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_decode_embeddertest.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M core/src/fxcodec/codec/codec_int.h View 4 chunks +40 lines, -14 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec.cpp View 1 chunk +115 lines, -0 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec_fax.cpp View 2 chunks +187 lines, -0 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec_flate.cpp View 9 chunks +172 lines, -29 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec_jpeg.cpp View 4 chunks +203 lines, -26 lines 0 comments Download
A core/src/fxge/ge/fx_ge_ps.cpp View 1 chunk +699 lines, -0 lines 0 comments Download
M pdfium.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Lei Zhang
TBR, sad trombone. I'll try again when I have access to a Windows machine, or ...
5 years ago (2015-12-22 22:36:46 UTC) #2
Lei Zhang
Committed patchset #1 (id:1) manually as be9095d0b2819cdc88785b0b4fdfccf837eb96a9 (tree was closed).
5 years ago (2015-12-22 22:37:10 UTC) #4
Oliver Chang
5 years ago (2015-12-22 22:40:39 UTC) #5
Message was sent while issue was closed.
On 2015/12/22 at 22:37:10, thestig wrote:
> Committed patchset #1 (id:1) manually as
be9095d0b2819cdc88785b0b4fdfccf837eb96a9 (tree was closed).

:(

lgtm

Powered by Google App Engine
This is Rietveld 408576698