Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 1540973005: dart2js: minify 'static:' tag (Closed)

Created:
5 years ago by sra1
Modified:
4 years, 12 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: minify 'static:' tag (For now, only in frequency based renamer) R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/731b9894b241b6a1b41e7779b91ca30a05308a60

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M pkg/compiler/lib/src/js_backend/frequency_namer.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/namer.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
sra1
Saves about 0.3% minified size, which disappears after gzip.
5 years ago (2015-12-23 00:17:33 UTC) #3
Siggi Cherem (dart-lang)
lgtm
5 years ago (2015-12-23 00:48:35 UTC) #4
sra1
4 years, 12 months ago (2015-12-29 00:12:21 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
731b9894b241b6a1b41e7779b91ca30a05308a60 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698