Switch to standard integer types in skia/.

Switch to standard integer types in skia/.

BUG=138542
TBR=thakis@chromium.org

Committed: https://crrev.com/cef19f73bf0d3652320b25ca0bc4bb13073fa222
Cr-Commit-Position: refs/heads/master@{#366609}

[Avi (use Gerrit), 2015-12-22 01:49:32]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2015-12-22 01:49:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1540963004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1540963004/1

[Nico, 2015-12-22 02:51:54]

https://codereview.chromium.org/1540963004/diff/1/skia/ext/SkDiscardableMemor...
File skia/ext/SkDiscardableMemory_chrome.cc (right):

https://codereview.chromium.org/1540963004/diff/1/skia/ext/SkDiscardableMemor...
skia/ext/SkDiscardableMemory_chrome.cc:7: #include <stddef.h>
why this include? nothing in this file was modified, and the size_t in the
argument comes in from the .h already (you don't need iwyu for stuff in the
class declaration)

[Nico, 2015-12-22 02:53:41]

The CQ bit was unchecked by thakis@chromium.org

[Nico, 2015-12-22 02:54:21]

i've unchecked cq. many of the includes this adds seem unnecessary to me (but
maybe i just don't understand why they're needed yet)

[Avi (use Gerrit), 2015-12-22 02:56:27]

https://codereview.chromium.org/1540963004/diff/1/skia/ext/SkDiscardableMemor...
File skia/ext/SkDiscardableMemory_chrome.cc (right):

https://codereview.chromium.org/1540963004/diff/1/skia/ext/SkDiscardableMemor...
skia/ext/SkDiscardableMemory_chrome.cc:7: #include <stddef.h>
On 2015/12/22 02:51:54, Nico wrote:
> why this include? nothing in this file was modified, and the size_t in the
> argument comes in from the .h already (you don't need iwyu for stuff in the
> class declaration)

I'm adding these includes in with a tool-assist. The tool can't tell the
difference between a size_t in a .cc that comes in via the associated .h, and
one used in the .cc that needs the header file. Right now, it's adding the
stddef.h to every file that uses it.

And don't tell me, "hey, nothing in this file was modified, so why do you need
to change the includes?" When I remove basictypes.h from some upstream file,
everything downstream explodes. Preemptively IWYU everywhere is the only way to
make this happen.

[Avi (use Gerrit), 2015-12-22 02:58:21]

On 2015/12/22 02:54:21, Nico wrote:
> i've unchecked cq. many of the includes this adds seem unnecessary to me (but
> maybe i just don't understand why they're needed yet)

Please come to talk to me in person. I won't yet re-check this, but I'm taking
the only approach I can see that's reasonable. Perhaps you can convince me
otherwise.

[Nico, 2015-12-22 03:28:57]

Yes, let's talk tomorrow. Please stop landing these in other directories
until then too.

On Mon, Dec 21, 2015 at 9:58 PM, <avi@chromium.org> wrote:

> On 2015/12/22 02:54:21, Nico wrote:
>
>> i've unchecked cq. many of the includes this adds seem unnecessary to me
>> (but
>> maybe i just don't understand why they're needed yet)
>>
>
> Please come to talk to me in person. I won't yet re-check this, but I'm
> taking
> the only approach I can see that's reasonable. Perhaps you can convince me
> otherwise.
>
> https://codereview.chromium.org/1540963004/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Avi (use Gerrit), 2015-12-22 16:42:15]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-22 16:42:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1540963004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1540963004/40001

[Avi (use Gerrit), 2015-12-22 17:05:42]

ptal

[Nico, 2015-12-22 17:13:28]

lgtm

https://codereview.chromium.org/1540963004/diff/40001/skia/ext/convolver.h
File skia/ext/convolver.h (right):

https://codereview.chromium.org/1540963004/diff/40001/skia/ext/convolver.h#ne...
skia/ext/convolver.h:8: #include <stdint.h>
i think this one isn't needed either, but int16_t is mentioned in a comment, so
ok

[Avi (use Gerrit), 2015-12-22 17:19:02]

The CQ bit was unchecked by avi@chromium.org

[Avi (use Gerrit), 2015-12-22 17:19:16]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2015-12-22 17:19:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1540963004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1540963004/40001

[commit-bot: I haz the power, 2015-12-22 17:47:31]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-22 17:48:24]

Description was changed from

==========
Switch to standard integer types in skia/.

BUG=138542
TBR=thakis@chromium.org
==========

to

==========
Switch to standard integer types in skia/.

BUG=138542
TBR=thakis@chromium.org

Committed: https://crrev.com/cef19f73bf0d3652320b25ca0bc4bb13073fa222
Cr-Commit-Position: refs/heads/master@{#366609}
==========

[commit-bot: I haz the power, 2015-12-22 17:48:25]

Patchset 3 (id:??) landed as
https://crrev.com/cef19f73bf0d3652320b25ca0bc4bb13073fa222
Cr-Commit-Position: refs/heads/master@{#366609}