Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1540923003: Append '\n' character to nanobench error message (Closed)

Created:
5 years ago by Chris Dalton
Modified:
4 years, 12 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Append '\n' character to nanobench error message This prevents the error message from inserting itself on a line before a bench result, which can mess up parsing. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1540923003 Committed: https://skia.googlesource.com/skia/+/20b4ca12114d0676da2fd61b99f1577678d33abe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M bench/ETCBitmapBench.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Chris Dalton
5 years ago (2015-12-21 22:15:57 UTC) #3
bsalomon
lgtm
4 years, 12 months ago (2015-12-22 17:04:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1540923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1540923003/1
4 years, 12 months ago (2015-12-22 18:32:13 UTC) #6
commit-bot: I haz the power
4 years, 12 months ago (2015-12-22 18:50:59 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/20b4ca12114d0676da2fd61b99f1577678d33abe

Powered by Google App Engine
This is Rietveld 408576698