editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java - Issue 15409004: Update CONST_CONSTRUCTOR_WITH_NON_FINAL_FIELD to check also super/mixin types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java

Issue 15409004: Update CONST_CONSTRUCTOR_WITH_NON_FINAL_FIELD to check also super/mixin types (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Move hasNonFinalField() to ClassElement Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/element/ClassElement.java ('k') | editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/element/ClassElementImpl.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java

diff --git a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java

index 13168097ad6e9c77a6cbf8c37de93c3482dd5d16..b3c645f63e39141b71b06c9f4aa23826b5a6ed60 100644

--- a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java

+++ b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java

@@ -124,9 +124,11 @@ public enum CompileTimeErrorCode implements ErrorCode {

/**

* 7.6.3 Constant Constructors: It is a compile-time error if a constant constructor is declared

* by a class that has a non-final instance variable.

+ * <p>

+ * The above refers to both locally declared and inherited instance variables.

CONST_CONSTRUCTOR_WITH_NON_FINAL_FIELD(

- "Classes with non-final fields cannot define 'const' constructors"),

+ "Cannot define the 'const' constructor for a class with non-final fields"),

/**

* 6.2 Formal Parameters: It is a compile-time error if a formal parameter is declared as a