Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1540893004: [runtime] Migrate GlobalEval to C++. (Closed)

Created:
5 years ago by Benedikt Meurer
Modified:
5 years ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Migrate GlobalEval to C++. The GlobalEval JavaScript function was just a small driver for stuff implemented in C++ anyway, so there's no point in having it around at all. The next step will be to move the Function constructor to C++ as well, which is the other user of %CompileString. R=yangguo@chromium.org BUG=chromium:535408 LOG=n Committed: https://crrev.com/a878dcfdbc8b5acdecaf112098b43d92ddbbdda5 Cr-Commit-Position: refs/heads/master@{#33006}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -15 lines) Patch
M src/bootstrapper.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/builtins.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/builtins.cc View 1 chunk +69 lines, -0 lines 0 comments Download
M src/js/v8natives.js View 3 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
5 years ago (2015-12-22 09:28:20 UTC) #1
Benedikt Meurer
Hey Yang, As mentioned offline, there are more yaks to shave here. Please take a ...
5 years ago (2015-12-22 09:29:22 UTC) #2
Yang
lgtm
5 years ago (2015-12-22 09:29:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1540893004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1540893004/1
5 years ago (2015-12-22 09:30:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-22 10:07:38 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-22 10:08:08 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a878dcfdbc8b5acdecaf112098b43d92ddbbdda5
Cr-Commit-Position: refs/heads/master@{#33006}

Powered by Google App Engine
This is Rietveld 408576698