Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Unified Diff: chromeos/binder/command_stream.cc

Issue 1540803002: Switch to standard integer types in chromeos/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: more includes Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/binder/command_stream.h ('k') | chromeos/binder/constants.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/binder/command_stream.cc
diff --git a/chromeos/binder/command_stream.cc b/chromeos/binder/command_stream.cc
index 3a0d00c31c08e60ec530733c1723c2ff9636ff94..e80c346a3dd9c1032ef0fdc0e3c1eb209a4e1166 100644
--- a/chromeos/binder/command_stream.cc
+++ b/chromeos/binder/command_stream.cc
@@ -5,6 +5,8 @@
#include "chromeos/binder/command_stream.h"
#include <linux/android/binder.h>
+#include <stddef.h>
+#include <stdint.h>
#include "base/bind.h"
#include "chromeos/binder/buffer_reader.h"
@@ -52,7 +54,7 @@ bool CommandStream::CanProcessIncomingCommand() {
bool CommandStream::ProcessIncomingCommand() {
DCHECK(thread_checker_.CalledOnValidThread());
DCHECK(CanProcessIncomingCommand());
- uint32 command = 0;
+ uint32_t command = 0;
if (!incoming_data_reader_->Read(&command, sizeof(command)) ||
!OnIncomingCommand(command, incoming_data_reader_.get())) {
LOG(ERROR) << "Error while handling command: " << command;
@@ -61,7 +63,7 @@ bool CommandStream::ProcessIncomingCommand() {
return true;
}
-void CommandStream::AppendOutgoingCommand(uint32 command,
+void CommandStream::AppendOutgoingCommand(uint32_t command,
const void* data,
size_t size) {
DCHECK(thread_checker_.CalledOnValidThread());
@@ -93,14 +95,14 @@ bool CommandStream::Flush() {
return true;
}
-bool CommandStream::OnIncomingCommand(uint32 command, BufferReader* reader) {
+bool CommandStream::OnIncomingCommand(uint32_t command, BufferReader* reader) {
DCHECK(thread_checker_.CalledOnValidThread());
// TODO(hashimoto): Replace all NOTIMPLEMENTED with logic to handle incoming
// commands.
VLOG(1) << "Processing " << CommandToString(command) << ", this = " << this;
switch (command) {
case BR_ERROR: {
- int32 error = 0;
+ int32_t error = 0;
if (!reader->Read(&error, sizeof(error))) {
LOG(ERROR) << "Failed to read error code.";
return false;
« no previous file with comments | « chromeos/binder/command_stream.h ('k') | chromeos/binder/constants.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698