Allow IAT patches to fail when patching for Active Verifier.

Allow IAT patches to fail when patching for Active Verifier.

Not all loaded modules import CloseHandle and DuplicateHandle so
InstallHandleHooks was failing incorrectly and causing the Handle
Verifier to be disabled.

Also, continue to patch DuplicateHandle if a module happens to
not import CloseHandle.

BUG=570912
Committed: https://crrev.com/c844be97c13fcf492149a21a0f3d9bf083c3c0d2
Cr-Commit-Position: refs/heads/master@{#366322}

[Will Harris, 2015-12-20 01:54:34]

Description was changed from

==========
Allow IAT patches to fail when patching for Active Verifier.

Not all loaded modules import CloseHandle and DuplicateHandle so
InstallHandleHooks was failing incorrectly and causing the Handle
Verifier to be disabled.

Also, continue to patch DuplicateHandle if a module happens to
not import CloseHandle.

BUG=570912
==========

to

==========
Allow IAT patches to fail when patching for Active Verifier.

Not all loaded modules import CloseHandle and DuplicateHandle so
InstallHandleHooks was failing incorrectly and causing the Handle
Verifier to be disabled.

Also, continue to patch DuplicateHandle if a module happens to
not import CloseHandle.

BUG=570912
==========

[Will Harris, 2015-12-20 01:54:34]

wfh@chromium.org changed reviewers:
+ cpu@chromium.org

[Will Harris, 2015-12-20 01:55:43]

PTAL as this is a major crasher right now (98% of browser crashes).

[cpu_(ooo_6.6-7.5), 2015-12-21 00:34:41]

lgtm

https://codereview.chromium.org/1540723002/diff/20001/base/debug/close_handle...
File base/debug/close_handle_hook_win.cc (right):

https://codereview.chromium.org/1540723002/diff/20001/base/debug/close_handle...
base/debug/close_handle_hook_win.cc:252: if
(!hooks->AddIATPatch(modules[current]))
add brackets, looks strange as is.

[Will Harris, 2015-12-21 01:25:25]

thanks for review.

https://codereview.chromium.org/1540723002/diff/20001/base/debug/close_handle...
File base/debug/close_handle_hook_win.cc (right):

https://codereview.chromium.org/1540723002/diff/20001/base/debug/close_handle...
base/debug/close_handle_hook_win.cc:252: if
(!hooks->AddIATPatch(modules[current]))
On 2015/12/21 00:34:41, cpu_slow_until_jan4 wrote:
> add brackets, looks strange as is.

Done.

[Will Harris, 2015-12-21 01:25:27]

The CQ bit was checked by wfh@chromium.org

[Will Harris, 2015-12-21 01:25:27]

The patchset sent to the CQ was uploaded after l-g-t-m from cpu@chromium.org
Link to the patchset: https://codereview.chromium.org/1540723002/#ps40001
(title: "code review change")

[commit-bot: I haz the power, 2015-12-21 01:25:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1540723002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1540723002/40001

[commit-bot: I haz the power, 2015-12-21 02:34:47]

Description was changed from

==========
Allow IAT patches to fail when patching for Active Verifier.

Not all loaded modules import CloseHandle and DuplicateHandle so
InstallHandleHooks was failing incorrectly and causing the Handle
Verifier to be disabled.

Also, continue to patch DuplicateHandle if a module happens to
not import CloseHandle.

BUG=570912
==========

to

==========
Allow IAT patches to fail when patching for Active Verifier.

Not all loaded modules import CloseHandle and DuplicateHandle so
InstallHandleHooks was failing incorrectly and causing the Handle
Verifier to be disabled.

Also, continue to patch DuplicateHandle if a module happens to
not import CloseHandle.

BUG=570912
==========

[commit-bot: I haz the power, 2015-12-21 02:34:48]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-21 02:35:18]

Description was changed from

==========
Allow IAT patches to fail when patching for Active Verifier.

Not all loaded modules import CloseHandle and DuplicateHandle so
InstallHandleHooks was failing incorrectly and causing the Handle
Verifier to be disabled.

Also, continue to patch DuplicateHandle if a module happens to
not import CloseHandle.

BUG=570912
==========

to

==========
Allow IAT patches to fail when patching for Active Verifier.

Not all loaded modules import CloseHandle and DuplicateHandle so
InstallHandleHooks was failing incorrectly and causing the Handle
Verifier to be disabled.

Also, continue to patch DuplicateHandle if a module happens to
not import CloseHandle.

BUG=570912

Committed: https://crrev.com/c844be97c13fcf492149a21a0f3d9bf083c3c0d2
Cr-Commit-Position: refs/heads/master@{#366322}
==========

[commit-bot: I haz the power, 2015-12-21 02:35:18]

Patchset 3 (id:??) landed as
https://crrev.com/c844be97c13fcf492149a21a0f3d9bf083c3c0d2
Cr-Commit-Position: refs/heads/master@{#366322}

[Finnur, 2015-12-21 10:21:08]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1542553002/ by finnur@chromium.org.

The reason for reverting is: Seems to consistently cause Win7 tests to fail.

Example log:
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%2....