core/src/fpdfdoc/doc_basic.cpp - Issue 1540693002: Get rid of a few CPDF_Object Create() methods and just use new instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfdoc/doc_basic.cpp

Issue 1540693002: Get rid of a few CPDF_Object Create() methods and just use new instead. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/src/fpdfdoc/doc_basic.cpp

diff --git a/core/src/fpdfdoc/doc_basic.cpp b/core/src/fpdfdoc/doc_basic.cpp

index d976650ae01676e86fa4935a20e3db9624b08849..3fb997878b72a6ec2d981244689d647ed858e1fa 100644

--- a/core/src/fpdfdoc/doc_basic.cpp

+++ b/core/src/fpdfdoc/doc_basic.cpp

@@ -329,7 +329,7 @@ FX_BOOL CPDF_FileSpec::GetFileName(CFX_WideString& csFileName) const {

return TRUE;

}

CPDF_FileSpec::CPDF_FileSpec() {

- m_pObj = CPDF_Dictionary::Create();

+ m_pObj = new CPDF_Dictionary;

if (CPDF_Dictionary* pDict = ToDictionary(m_pObj)) {

pDict->SetAtName("Type", "Filespec");

}

« no previous file with comments | « core/src/fpdfdoc/doc_ap.cpp ('k') | core/src/fpdfdoc/doc_form.cpp » ('j') | no next file with comments »