Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 1540673002: Move super initializer to end of list (Closed)

Created:
5 years ago by hausner
Modified:
5 years ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move super initializer to end of list. Introduce --warn_super flag to print a warning when a super call is found that is not at the end of the initializer list. Mark failing tests as Fail, OK. In a later step, we can eliminate the implicit 'phase' parameter in constructors. BUG= R=iposva@google.com Committed: https://github.com/dart-lang/sdk/commit/f51f96816d677c99fee1974d0c30cb9606bc9c03

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -4 lines) Patch
M runtime/vm/parser.cc View 1 2 chunks +6 lines, -2 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 1 chunk +5 lines, -0 lines 0 comments Download
M tests/language/language.status View 1 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
hausner
5 years ago (2015-12-18 22:00:28 UTC) #4
Ivan Posva
LGTM -ip https://codereview.chromium.org/1540673002/diff/1/tests/co19/co19-runtime.status File tests/co19/co19-runtime.status (right): https://codereview.chromium.org/1540673002/diff/1/tests/co19/co19-runtime.status#newcode8 tests/co19/co19-runtime.status:8: Language/Classes/Constructors/Generative_Constructors/execution_t03: Fail, OK # why...
5 years ago (2015-12-18 23:26:16 UTC) #5
hausner
Committed patchset #2 (id:20001) manually as f51f96816d677c99fee1974d0c30cb9606bc9c03 (presubmit successful).
5 years ago (2015-12-18 23:37:12 UTC) #7
hausner
5 years ago (2015-12-18 23:37:56 UTC) #8
Message was sent while issue was closed.
https://codereview.chromium.org/1540673002/diff/1/tests/co19/co19-runtime.status
File tests/co19/co19-runtime.status (right):

https://codereview.chromium.org/1540673002/diff/1/tests/co19/co19-runtime.sta...
tests/co19/co19-runtime.status:8:
Language/Classes/Constructors/Generative_Constructors/execution_t03: Fail, OK
On 2015/12/18 23:26:16, Ivan Posva wrote:
>  # why...

Done.

Powered by Google App Engine
This is Rietveld 408576698