Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1216)

Unified Diff: gpu/command_buffer/client/gles2_implementation.cc

Issue 1540553003: Revert of Command Buffer: read pixels into pixel pack buffer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/client/gles2_implementation.cc
diff --git a/gpu/command_buffer/client/gles2_implementation.cc b/gpu/command_buffer/client/gles2_implementation.cc
index cebd672bef2b4beba173c48a44d9631844dd34da..587a5db07d5513758a194ac285f3bd7f0a1d1620 100644
--- a/gpu/command_buffer/client/gles2_implementation.cc
+++ b/gpu/command_buffer/client/gles2_implementation.cc
@@ -3541,10 +3541,10 @@
}
if (bound_pixel_pack_buffer_) {
- GLuint offset = ToGLuint(pixels);
- helper_->ReadPixels(
- xoffset, yoffset, width, height, format, type, 0, offset, 0, 0, false);
- CheckGLError();
+ // TODO(zmo): Need to handle the case of reading into a PIXEL_PACK_BUFFER
+ // in ES3. For now, generate a GL error.
+ SetGLError(GL_INVALID_OPERATION, "glReadPixels",
+ "ReadPixels to a pixel pack buffer isn't implemented");
return;
}
« no previous file with comments | « no previous file | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698