Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1689)

Issue 1540553003: Revert of Command Buffer: read pixels into pixel pack buffer (Closed)

Created:
5 years ago by Jamie Madill
Modified:
5 years ago
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Command Buffer: read pixels into pixel pack buffer (patchset #9 id:260001 of https://codereview.chromium.org/1320093002/ ) Reason for revert: Causes a timeout in Windows Debug, possibly an ASSERT: http://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Debug%20%28NVIDIA%29/builds/12003/steps/webgl2_conformance_tests/logs/stdio WebglConformance.conformance2_reading_read_pixels_into_pixel_pack_buffer times out Original issue's description: > Command Buffer: read pixels into pixel pack buffer > > TEST=conformance2/reading/read-pixels-into-pixel-pack-buffer.html, gpu_unittests > > BUG=429053 > > Committed: https://crrev.com/0b1fc5d170a52839cd7cdba069c3b79bc0a4aa21 > Cr-Commit-Position: refs/heads/master@{#365989} TBR=kbr@chromium.org,zmo@chromium.org,bajones@chromium.org,piman@chromium.org,qiankun.miao@intel.com,yunchao.he@intel.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=429053 Committed: https://crrev.com/56a004b10b0b2251b7a6b9e16eca4e36cb6eb4c2 Cr-Commit-Position: refs/heads/master@{#366091}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -233 lines) Patch
M gpu/command_buffer/client/gles2_implementation.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 3 chunks +24 lines, -70 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc View 1 chunk +0 lines, -148 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jamie Madill
Created Revert of Command Buffer: read pixels into pixel pack buffer
5 years ago (2015-12-18 15:06:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1540553003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1540553003/1
5 years ago (2015-12-18 15:06:41 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-18 15:07:39 UTC) #4
commit-bot: I haz the power
5 years ago (2015-12-18 15:08:34 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/56a004b10b0b2251b7a6b9e16eca4e36cb6eb4c2
Cr-Commit-Position: refs/heads/master@{#366091}

Powered by Google App Engine
This is Rietveld 408576698