Uniquify profile shortcut name.

chrome/browser/profiles/profile_shortcut_manager_win.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PROFILES_PROFILE_SHORTCUT_MANAGER_WIN_H_
 #define CHROME_BROWSER_PROFILES_PROFILE_SHORTCUT_MANAGER_WIN_H_
 
+#include <set>
+
 #include "base/callback.h"
 #include "chrome/browser/profiles/profile_shortcut_manager.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_registrar.h"
 
 class BrowserDistribution;
 
 // Internal free-standing functions that are exported here for testing.
 namespace profiles {
 namespace internal {
 
 // Returns the full path to the profile icon file.
 base::FilePath GetProfileIconPath(const base::FilePath& profile_path);
 
 // Returns the default shortcut filename for the given profile name,
 // given |distribution|. Returns a filename appropriate for a
 // single-user installation if |profile_name| is empty.
 base::string16 GetShortcutFilenameForProfile(const base::string16& profile_name,
                                              BrowserDistribution* distribution);
 
+// The same as above but uniqueness is guaranteed.

[anthonyvd, 2016/01/04 16:30:18]

nit: maybe name the function directly so this comment isn't made invalid by
something being inserted between the 2 functions.

+base::string16 GetShortcutUniqueFilenameForProfile(

[Alexei Svitkine (slow), 2016/01/05 19:55:22]

Nit: GetUniqueShortcutFilenameForProfile().

+    const base::string16& profile_name,
+    BrowserDistribution* distribution,
+    const std::set<base::FilePath>& excludes);
+
+class ShortcutFilenameMatcher {

[Alexei Svitkine (slow), 2016/01/05 19:55:22]

Add a comment about the purpose of this class.

+ public:
+  ShortcutFilenameMatcher(const base::string16& profile_name,
+                          BrowserDistribution* distribution);
+
+  // Check that shortcut filename has a name given by us (by
+  // GetShortcutFilenameForProfile or GetShortcutUniqueFilenameForProfile).
+  bool IsCanonical(const base::string16& filename) const;
+
+ private:
+  const base::string16 profile_shortcut_filename_;
+  const base::StringPiece16 lnk_ext_;
+  base::StringPiece16 profile_shortcut_name_;
+};

[Alexei Svitkine (slow), 2016/01/05 19:55:22]

Nit: DISALLOW_COPY_AND_ASSIGN()

+
 // Returns the command-line flags to launch Chrome with the given profile.
 base::string16 CreateProfileShortcutFlags(const base::FilePath& profile_path);
 
 }  // namespace internal
 }  // namespace profiles
 
 class ProfileShortcutManagerWin : public ProfileShortcutManager,
                                   public ProfileInfoCacheObserver,
                                   public content::NotificationObserver {
  public:
@@ skipping 52 matching lines @@
       NonProfileShortcutAction action);
 
   ProfileManager* profile_manager_;
 
   content::NotificationRegistrar registrar_;
 
   DISALLOW_COPY_AND_ASSIGN(ProfileShortcutManagerWin);
 };
 
 #endif  // CHROME_BROWSER_PROFILES_PROFILE_SHORTCUT_MANAGER_WIN_H_