Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 1540533002: Fix for typedef-typed field formal parameter. (Closed)

Created:
5 years ago by scheglov
Modified:
5 years ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for typedef-typed field formal parameter. Found it while generating SDK summaries. But this is the only exception - the rest worked fine. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/0e283fe46f50a2625171c4791ed461fd56dcffe1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -8 lines) Patch
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 2 chunks +7 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_test.dart View 6 chunks +16 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
5 years ago (2015-12-18 07:23:53 UTC) #1
Paul Berry
lgtm
5 years ago (2015-12-18 15:09:01 UTC) #2
scheglov
5 years ago (2015-12-18 15:54:16 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0e283fe46f50a2625171c4791ed461fd56dcffe1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698