Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(767)

Unified Diff: chrome/browser/extensions/api/activity_log_private/activity_log_private_api.cc

Issue 154053004: Introducing the activityLogPrivate.deleteActivities() API call. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/activity_log_private/activity_log_private_api.cc
diff --git a/chrome/browser/extensions/api/activity_log_private/activity_log_private_api.cc b/chrome/browser/extensions/api/activity_log_private/activity_log_private_api.cc
index 1b7a2a93a3d46396559d5ea1e826723067d91862..8e54d1f9b6aedd606fac40b59dbb59ba20553ac1 100644
--- a/chrome/browser/extensions/api/activity_log_private/activity_log_private_api.cc
+++ b/chrome/browser/extensions/api/activity_log_private/activity_log_private_api.cc
@@ -174,6 +174,25 @@ void ActivityLogPrivateGetExtensionActivitiesFunction::OnLookupCompleted(
SendResponse(true);
}
+bool ActivityLogPrivateDeleteActivitiesFunction::RunImpl() {
+ scoped_ptr<activity_log_private::DeleteActivities::Params> params(
+ activity_log_private::DeleteActivities::Params::Create(*args_));
+ EXTENSION_FUNCTION_VALIDATE(params.get());
+
+ // Put the arguments in the right format.
+ std::vector<int64> action_ids;
+ int64 value;
+ for (size_t i = 0; i < params->activity_ids.size(); i++) {
+ if (base::StringToInt64(params->activity_ids[i], &value))
felt 2014/02/13 00:58:56 should you be throwing an exception if it fails to
+ action_ids.push_back(value);
+ }
+
+ ActivityLog* activity_log = ActivityLog::GetInstance(GetProfile());
+ DCHECK(activity_log);
+ activity_log->RemoveActions(action_ids);
+ return true;
+}
+
bool ActivityLogPrivateDeleteDatabaseFunction::RunImpl() {
ActivityLog* activity_log = ActivityLog::GetInstance(GetProfile());
DCHECK(activity_log);

Powered by Google App Engine
This is Rietveld 408576698