Chromium Code Reviews

Issue 154053002: Reland "Gyp file changes for the android framework." (Closed)

Created:
6 years, 10 months ago by scroggo
Modified:
6 years, 10 months ago
Reviewers:
djsollen
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Reland "Gyp file changes for the android framework." Relands https://codereview.chromium.org/153093003/, which was reverted with https://skia.googlesource.com/skia.git/+/eb6295044b97db05ec40625dcebc2459b2a38a98 This reverts commit 6b32be1402eb6c549d5ba1db71860e24f9de2991. BUG=skia:1975 R=djsollen@google.com Committed: https://code.google.com/p/skia/source/detail?r=13321

Patch Set 1 #

Patch Set 2 : Fix android build. #

Unified diffs Side-by-side diffs Stats (+255 lines, -41 lines)
M gyp/android_deps.gyp View 1 chunk +63 lines, -2 lines 0 comments
A gyp/android_framework_lib.gyp View 1 chunk +20 lines, -0 lines 0 comments
M gyp/common.gypi View 1 chunk +24 lines, -19 lines 0 comments
M gyp/common_conditions.gypi View 2 chunks +28 lines, -0 lines 0 comments
M gyp/common_variables.gypi View 3 chunks +12 lines, -2 lines 0 comments
M gyp/core.gyp View 1 chunk +6 lines, -0 lines 0 comments
M gyp/freetype.gyp View 1 chunk +16 lines, -0 lines 0 comments
M gyp/images.gyp View 3 chunks +24 lines, -6 lines 0 comments
M gyp/libwebp.gyp View 2 chunks +32 lines, -10 lines 0 comments
M gyp/opts.gyp View 2 chunks +4 lines, -1 line 0 comments
M gyp/pdf.gyp View 2 chunks +15 lines, -0 lines 0 comments
M gyp/zlib.gyp View 2 chunks +11 lines, -1 line 0 comments

Messages

Total messages: 3 (0 generated)
scroggo
Patch set 1 is a pure revert, and patch set 2 fixes the problem with ...
6 years, 10 months ago (2014-02-04 17:10:18 UTC) #1
djsollen
lgtm
6 years, 10 months ago (2014-02-04 17:47:17 UTC) #2
scroggo
6 years, 10 months ago (2014-02-05 16:35:20 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 manually as r13321 (presubmit successful).

Powered by Google App Engine