 Chromium Code Reviews
 Chromium Code Reviews Issue 1540463003:
  Change the interface of GetAlternativeServicesFor, always return the best Alt-Svc entry.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 1540463003:
  Change the interface of GetAlternativeServicesFor, always return the best Alt-Svc entry.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: net/quic/quic_stream_factory.cc | 
| diff --git a/net/quic/quic_stream_factory.cc b/net/quic/quic_stream_factory.cc | 
| index e48985d2ef323b1bba210ba73b29e604b6ee6b6e..73dc36672c35b99daccb1a22bec8a3b0665a9df8 100644 | 
| --- a/net/quic/quic_stream_factory.cc | 
| +++ b/net/quic/quic_stream_factory.cc | 
| @@ -27,7 +27,6 @@ | 
| #include "net/cert/ct_verifier.h" | 
| #include "net/dns/host_resolver.h" | 
| #include "net/dns/single_request_host_resolver.h" | 
| -#include "net/http/http_server_properties.h" | 
| #include "net/quic/crypto/channel_id_chromium.h" | 
| #include "net/quic/crypto/proof_verifier_chromium.h" | 
| #include "net/quic/crypto/properties_based_quic_server_info.h" | 
| @@ -710,6 +709,19 @@ void QuicStreamFactory::set_quic_server_info_factory( | 
| quic_server_info_factory_.reset(quic_server_info_factory); | 
| } | 
| +bool QuicStreamFactory::CanUseExistingSession(QuicServerId server_id, | 
| + PrivacyMode privacy_mode, | 
| + StringPiece origin_host) { | 
| + // TODO(zhongyi): crbug.com/498823 - delete active_sessions_.empty() checks. | 
| 
Ryan Hamilton
2016/01/05 23:51:58
Can you say more about this?
 
Zhongyi Shi
2016/01/06 02:31:40
I talked to raman earlier about that bug, this is
 | 
| + if (active_sessions_.empty()) | 
| + return false; | 
| + SessionMap::iterator it = active_sessions_.find(server_id); | 
| + if (it == active_sessions_.end()) | 
| + return false; | 
| + QuicChromiumClientSession* session = it->second; | 
| + return session->CanPool(origin_host.as_string(), privacy_mode); | 
| +} | 
| + | 
| int QuicStreamFactory::Create(const HostPortPair& host_port_pair, | 
| PrivacyMode privacy_mode, | 
| int cert_verify_flags, |