net/http/http_stream_factory_impl.h - Issue 1540463003: Change the interface of GetAlternativeServicesFor, always return the best Alt-Svc entry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_stream_factory_impl.h

Issue 1540463003: Change the interface of GetAlternativeServicesFor, always return the best Alt-Svc entry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Query quic_stream_factory to select preferred alt svc Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/http_stream_factory_impl.h

diff --git a/net/http/http_stream_factory_impl.h b/net/http/http_stream_factory_impl.h

index 6ed8b2ccee37636e284687862490d773e704b791..50b4773d16c32f31b66d21e12c0aee8a86a70815 100644

--- a/net/http/http_stream_factory_impl.h

+++ b/net/http/http_stream_factory_impl.h

@@ -74,8 +74,8 @@ class NET_EXPORT_PRIVATE HttpStreamFactoryImpl : public HttpStreamFactory {

WebSocketHandshakeStreamBase::CreateHelper* create_helper,

const BoundNetLog& net_log);

- AlternativeServiceVector GetAlternativeServicesFor(

- const GURL& original_url,

+ AlternativeService GetAlternativeServiceFor(

+ const HttpRequestInfo& request_info,

HttpStreamRequest::Delegate* delegate);

// Detaches |job| from |request|.

« no previous file with comments | « no previous file | net/http/http_stream_factory_impl.cc » ('j') | net/http/http_stream_factory_impl.cc » ('J')