Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 1540463002: Remove old GetRenderManager call from NavigatorImpl. (Closed)

Created:
5 years ago by Charlie Reis
Modified:
5 years ago
Reviewers:
alexmos
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove old GetRenderManager call from NavigatorImpl. Falling back to the main frame's RenderFrameHostManager is fragile and should be avoided. BUG=495161 TEST=No behavior change Committed: https://crrev.com/f9d500f6601e16b96f78e7cb01f5a0c3a040ed1f Cr-Commit-Position: refs/heads/master@{#366136}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -10 lines) Patch
M content/browser/frame_host/navigator_impl.cc View 3 chunks +11 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Charlie Reis
Here's the first bit of cleanup after https://codereview.chromium.org/1519943002/. I found a few other bugs and ...
5 years ago (2015-12-18 07:46:09 UTC) #2
alexmos
LGTM, thanks for the cleanup!
5 years ago (2015-12-18 18:40:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1540463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1540463002/1
5 years ago (2015-12-18 18:43:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-18 19:11:41 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-18 19:13:11 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f9d500f6601e16b96f78e7cb01f5a0c3a040ed1f
Cr-Commit-Position: refs/heads/master@{#366136}

Powered by Google App Engine
This is Rietveld 408576698