Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 1540453002: [turbofan] Drop 'auto' from register-allocator.cc (Closed)

Created:
5 years ago by Mircea Trofin
Modified:
5 years ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Drop 'auto' from register-allocator.cc Pretty much everywhere except for a few places where we use iterators. BUG= Committed: https://crrev.com/a44db0527ff5823bc65761f2e438402fd8805571 Cr-Commit-Position: refs/heads/master@{#32962}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+229 lines, -207 lines) Patch
M src/compiler/register-allocator.cc View 115 chunks +229 lines, -207 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Mircea Trofin
5 years ago (2015-12-17 23:35:43 UTC) #3
Benedikt Meurer
lgtm
5 years ago (2015-12-18 07:20:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1540453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1540453002/1
5 years ago (2015-12-18 07:26:11 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-18 07:27:35 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-18 07:27:56 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a44db0527ff5823bc65761f2e438402fd8805571
Cr-Commit-Position: refs/heads/master@{#32962}

Powered by Google App Engine
This is Rietveld 408576698