third_party/WebKit/Source/core/layout/LayoutInline.cpp - Issue 1540443003: Fix LayoutObject::mapToVisibleRectInContainerSpace()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutInline.cpp

Issue 1540443003: Fix LayoutObject::mapToVisibleRectInContainerSpace() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/LayoutBox.h ('K') | « third_party/WebKit/Source/core/layout/LayoutBox.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutObject.cpp » ('j') | third_party/WebKit/Source/core/layout/LayoutObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutInline.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutInline.cpp b/third_party/WebKit/Source/core/layout/LayoutInline.cpp

index 38409e27e12b9f4d2d0da138e835827dc7cfb289..aa10c8a6d85319c3b077bc8e5222d527529438ed 100644

--- a/third_party/WebKit/Source/core/layout/LayoutInline.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutInline.cpp

@@ -1104,11 +1104,7 @@ void LayoutInline::mapToVisibleRectInContainerSpace(const LayoutBoxModelObject*

// its controlClipRect will be wrong. For overflow clip we use the values cached by the layer.

rect.setLocation(topLeft);

if (o->hasOverflowClip()) {

- LayoutBox* containerBox = toLayoutBox(o);

- if (o == paintInvalidationContainer)

- containerBox->applyCachedScrollOffsetForPaintInvalidation(rect);

- else

- containerBox->applyCachedClipAndScrollOffsetForPaintInvalidation(rect);

+ toLayoutBox(o)->applyCachedClipAndScrollOffsetForPaintInvalidationIfNeeded(paintInvalidationContainer, rect);

if (rect.isEmpty())

return;

}