Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6608)

Unified Diff: chrome/browser/ui/autofill/chrome_autofill_client.cc

Issue 1540423004: Add card details and legal message to Android save credit card infobar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: components/autofill review. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/chrome_autofill_client.cc
diff --git a/chrome/browser/ui/autofill/chrome_autofill_client.cc b/chrome/browser/ui/autofill/chrome_autofill_client.cc
index ca159ec0f37442f0cd4f97a2601ba3bc33dd2445..1dad3243d4e823ac22f3522917f3b8c150f72251 100644
--- a/chrome/browser/ui/autofill/chrome_autofill_client.cc
+++ b/chrome/browser/ui/autofill/chrome_autofill_client.cc
@@ -53,6 +53,12 @@
#include "components/ui/zoom/zoom_controller.h"
#endif
+#if defined(OS_ANDROID) || defined(OS_IOS)
+#include "components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.h"
+#include "components/autofill/core/browser/autofill_save_card_infobar_mobile.h"
+#include "components/infobars/core/infobar.h"
+#endif
+
DEFINE_WEB_CONTENTS_USER_DATA_KEY(autofill::ChromeAutofillClient);
namespace autofill {
@@ -174,8 +180,15 @@ void ChromeAutofillClient::OnUnmaskVerificationResult(
}
void ChromeAutofillClient::ConfirmSaveCreditCardLocally(
+ const CreditCard& card,
const base::Closure& callback) {
-#if !defined(OS_ANDROID)
+#if defined(OS_ANDROID) || defined(OS_IOS)
+ InfoBarService::FromWebContents(web_contents())->AddInfoBar(
+ CreateSaveCardInfoBarMobile(
+ make_scoped_ptr(new AutofillSaveCardInfoBarDelegateMobile(
+ false, card, scoped_ptr<base::DictionaryValue>(nullptr),
+ callback))));
+#else
if (IsSaveCardBubbleEnabled()) {
// Do lazy initialization of SaveCardBubbleControllerImpl.
autofill::SaveCardBubbleControllerImpl::CreateForWebContents(
@@ -185,18 +198,21 @@ void ChromeAutofillClient::ConfirmSaveCreditCardLocally(
controller->ShowBubbleForLocalSave(callback);
return;
}
-#endif
+
AutofillCCInfoBarDelegate::CreateForLocalSave(
InfoBarService::FromWebContents(web_contents()), callback);
+#endif
}
void ChromeAutofillClient::ConfirmSaveCreditCardToCloud(
- const base::Closure& callback,
- scoped_ptr<base::DictionaryValue> legal_message) {
-// TODO(jdonnelly): Implement save card prompt for OS_IOS.
-#if defined(OS_ANDROID)
- AutofillCCInfoBarDelegate::CreateForUpload(
- InfoBarService::FromWebContents(web_contents()), callback);
+ const CreditCard& card,
+ scoped_ptr<base::DictionaryValue> legal_message,
+ const base::Closure& callback) {
+#if defined(OS_ANDROID) || defined(OS_IOS)
+ InfoBarService::FromWebContents(web_contents())->AddInfoBar(
+ CreateSaveCardInfoBarMobile(
+ make_scoped_ptr(new AutofillSaveCardInfoBarDelegateMobile(
+ true, card, std::move(legal_message), callback))));
#else
// Do lazy initialization of SaveCardBubbleControllerImpl.
autofill::SaveCardBubbleControllerImpl::CreateForWebContents(web_contents());
« no previous file with comments | « chrome/browser/ui/autofill/chrome_autofill_client.h ('k') | chrome/browser/ui/autofill/save_card_bubble_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698