Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/autofill/core/browser/legal_message_line_unittest.cc

Issue 1540423004: Add card details and legal message to Android save credit card infobar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Allow copying LegalMessageLine. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« components/autofill/core/browser/legal_message_line.cc ('K') | « components/autofill/core/browser/legal_message_line.cc ('k') | components/autofill/core/browser/test_autofill_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/core/browser/legal_message_line_unittest.cc
diff --git a/components/autofill/core/browser/legal_message_line_unittest.cc b/components/autofill/core/browser/legal_message_line_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..e908146f46500c46979dd2f7530168ca4169a1e4
--- /dev/null
+++ b/components/autofill/core/browser/legal_message_line_unittest.cc
@@ -0,0 +1,314 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/autofill/core/browser/legal_message_line.h"
+
+#include <string>
+#include <utility>
+
+#include "base/json/json_reader.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/strings/utf_string_conversions.h"
+#include "base/values.h"
+#include "testing/gmock/include/gmock/gmock.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace autofill {
+
+// A legal message line that allows for modifications.
+class TestLegalMessageLine : public LegalMessageLine {
+ public:
+ TestLegalMessageLine() {}
+
+ TestLegalMessageLine(const std::string& ascii_text) { set_text(ascii_text); }
+
+ TestLegalMessageLine(const std::string& ascii_text,
+ const std::vector<Link>& links) {
+ set_text(ascii_text);
+ set_links(links);
+ }
+
+ ~TestLegalMessageLine() override {}
+
+ void set_text(const std::string& ascii_text) {
+ text_ = base::ASCIIToUTF16(ascii_text);
+ }
+
+ void set_links(const std::vector<Link>& links) { links_ = links; }
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(TestLegalMessageLine);
+};
+
+// A conveniently constructable link.
+struct TestLink : public LegalMessageLine::Link {
+ TestLink(int start, int end, const std::string& url_spec) {
+ range.set_start(start);
+ range.set_end(end);
+ url = GURL(url_spec);
+ }
+};
+
+struct TestCase {
+ std::string message_json;
+ LegalMessageLines expected_lines;
+};
+
+std::ostream& operator<<(std::ostream& os, const LegalMessageLine& obj) {
+ os << "{text: '" << obj.text() << "', links: [";
+ for (const LegalMessageLine::Link& link : obj.links()) {
+ os << "{range: (" << link.range.start() << ", " << link.range.end()
+ << "), url: '" << link.url << "'}";
+ }
+
+ os << "]}";
+ return os;
+}
+
+std::ostream& operator<<(std::ostream& os, const LegalMessageLines& lines) {
+ os << "[";
+ for (const LegalMessageLine& line : lines)
+ os << line;
+
+ os << "]";
+ return os;
+}
+
+std::ostream& operator<<(std::ostream& os, const TestCase& test_case) {
+ os << "{message_json: '" << test_case.message_json
+ << "', expected_lines: " << test_case.expected_lines << "}";
+ return os;
+}
+
+class LegalMessageLineTest : public ::testing::TestWithParam<TestCase> {
+ public:
+ LegalMessageLineTest() {}
+ ~LegalMessageLineTest() override {}
+};
+
+bool operator==(const LegalMessageLine& lhs, const LegalMessageLine& rhs) {
+ if (lhs.text() != rhs.text() || lhs.links().size() != rhs.links().size())
+ return false;
+
+ for (size_t i = 0; i < lhs.links().size(); ++i) {
+ if (lhs.links()[i].range != rhs.links()[i].range)
+ return false;
+
+ if (lhs.links()[i].url != rhs.links()[i].url)
+ return false;
+ }
+
+ return true;
+}
+
+TEST_P(LegalMessageLineTest, Parsing) {
+ scoped_ptr<base::Value> value(
+ base::JSONReader::Read(GetParam().message_json));
+ ASSERT_TRUE(value);
+ base::DictionaryValue* dictionary = nullptr;
+ EXPECT_TRUE(value->GetAsDictionary(&dictionary));
+ ASSERT_TRUE(dictionary);
+ LegalMessageLines actual_lines;
+ LegalMessageLine::Parse(*dictionary, &actual_lines);
+
+ EXPECT_EQ(GetParam().expected_lines, actual_lines);
+};
+
+INSTANTIATE_TEST_CASE_P(
+ TestCases,
+ LegalMessageLineTest,
+ testing::Values(
+ TestCase{"{"
+ " \"line\" : [ {"
+ " \"template\": \"This is the entire message.\""
+ " } ]"
+ "}",
+ {TestLegalMessageLine("This is the entire message.")}},
+ TestCase{"{"
+ " \"line\" : [ {"
+ " \"template\": \"Panda {0}.\","
+ " \"template_parameter\": [ {"
+ " \"display_text\": \"bears are fuzzy\","
+ " \"url\": \"http://www.example.com\""
+ " } ]"
+ " } ]"
+ "}",
+ {TestLegalMessageLine{
+ "Panda bears are fuzzy.",
+ {TestLink(6, 21, "http://www.example.com")}}}},
+ // Legal message is invalid, so lines should be empty.
+ TestCase{"{"
+ " \"line\" : [ {"
+ " \"template\": \"Panda {0}.\","
+ " \"template_parameter\": [ {"
+ " \"display_text\": \"bear\""
+ " } ]"
+ " } ]"
+ "}",
+ LegalMessageLines()},
+ TestCase{"{"
+ " \"line\" : [ {"
+ " \"template\": \"Panda {0}.\","
+ " \"template_parameter\": [ {"
+ " \"url\": \"http://www.example.com\""
+ " } ]"
+ " } ]"
+ "}",
+ // Legal message is invalid, so lines should be empty.
+ LegalMessageLines()},
+ TestCase{"{"
+ " \"line\" : [ {"
+ " \"template\": \"Panda '{'{0}'}' '{1}' don't $1.\","
+ " \"template_parameter\": [ {"
+ " \"display_text\": \"bears\","
+ " \"url\": \"http://www.example.com\""
+ " } ]"
+ " } ]"
+ "}",
+ {TestLegalMessageLine(
+ "Panda {bears} {1} don't $1.",
+ {TestLink(7, 12, "http://www.example.com")})}},
+ // Consecutive dollar signs do not expand correctly (see comment in
+ // ReplaceTemplatePlaceholders() in legal_message_line.cc). If this is
+ // fixed and this test starts to fail, please update the "Caveats"
+ // section of the LegalMessageLine::Parse() header file comment.
+ TestCase{"{"
+ " \"line\" : [ {"
+ " \"template\": \"$$\""
+ " } ]"
+ "}",
+ {TestLegalMessageLine("$$$")}},
+ // "${" does not expand correctly (see comment in
+ // ReplaceTemplatePlaceholders() in legal_message_line.cc). If this is
+ // fixed and this test starts to fail, please update the "Caveats"
+ // section of the LegalMessageLine::Parse() header file comment.
+ TestCase{"{"
+ " \"line\" : [ {"
+ " \"template\": \"${0}\","
+ " \"template_parameter\": [ {"
+ " \"display_text\": \"bears\","
+ " \"url\": \"http://www.example.com\""
+ " } ]"
+ " } ]"
+ "}",
+ LegalMessageLines()},
+ TestCase{"{"
+ " \"line\" : [ {"
+ " \"template\": \"Panda {0} like {2} eat {1}.\","
+ " \"template_parameter\": [ {"
+ " \"display_text\": \"bears\","
+ " \"url\": \"http://www.example.com/0\""
+ " }, {"
+ " \"display_text\": \"bamboo\","
+ " \"url\": \"http://www.example.com/1\""
+ " }, {"
+ " \"display_text\": \"to\","
+ " \"url\": \"http://www.example.com/2\""
+ " } ]"
+ " } ]"
+ "}",
+ {TestLegalMessageLine(
+ "Panda bears like to eat bamboo.",
+ {TestLink(6, 11, "http://www.example.com/0"),
+ TestLink(24, 30, "http://www.example.com/1"),
+ TestLink(17, 19, "http://www.example.com/2")})}},
+ TestCase{
+ "{"
+ " \"line\" : [ {"
+ " \"template\": \"Panda {0}\","
+ " \"template_parameter\": [ {"
+ " \"display_text\": \"bears\","
+ " \"url\": \"http://www.example.com/line_0_param_0\""
+ " } ]"
+ " }, {"
+ " \"template\": \"like {1} eat {0}.\","
+ " \"template_parameter\": [ {"
+ " \"display_text\": \"bamboo\","
+ " \"url\": \"http://www.example.com/line_1_param_0\""
+ " }, {"
+ " \"display_text\": \"to\","
+ " \"url\": \"http://www.example.com/line_1_param_1\""
+ " } ]"
+ " }, {"
+ " \"template\": \"The {0}.\","
+ " \"template_parameter\": [ {"
+ " \"display_text\": \"end\","
+ " \"url\": \"http://www.example.com/line_2_param_0\""
+ " } ]"
+ " } ]"
+ "}",
+ {TestLegalMessageLine(
+ "Panda bears",
+ {TestLink(6, 11, "http://www.example.com/line_0_param_0")}),
+ TestLegalMessageLine(
+ "like to eat bamboo.",
+ {TestLink(12, 18, "http://www.example.com/line_1_param_0"),
+ TestLink(5, 7, "http://www.example.com/line_1_param_1")}),
+ TestLegalMessageLine(
+ "The end.",
+ {TestLink(4, 7, "http://www.example.com/line_2_param_0")})
+
+ }},
+ TestCase{"{"
+ " \"line\" : [ {"
+ " \"template\": \"Panda {0}\nlike {2} eat {1}.\nThe {3}.\","
+ " \"template_parameter\": [ {"
+ " \"display_text\": \"bears\","
+ " \"url\": \"http://www.example.com/0\""
+ " }, {"
+ " \"display_text\": \"bamboo\","
+ " \"url\": \"http://www.example.com/1\""
+ " }, {"
+ " \"display_text\": \"to\","
+ " \"url\": \"http://www.example.com/2\""
+ " }, {"
+ " \"display_text\": \"end\","
+ " \"url\": \"http://www.example.com/3\""
+ " } ]"
+ " } ]"
+ "}",
+ {TestLegalMessageLine(
+ "Panda bears\nlike to eat bamboo.\nThe end.",
+ {TestLink(6, 11, "http://www.example.com/0"),
+ TestLink(24, 30, "http://www.example.com/1"),
+ TestLink(17, 19, "http://www.example.com/2"),
+ TestLink(36, 39, "http://www.example.com/3")})}},
+ TestCase{"{"
+ " \"line\" : [ {"
+ " \"template\": \"a{0} b{1} c{2} d{3} e{4} f{5} g{6}\","
+ " \"template_parameter\": [ {"
+ " \"display_text\": \"A\","
+ " \"url\": \"http://www.example.com/0\""
+ " }, {"
+ " \"display_text\": \"B\","
+ " \"url\": \"http://www.example.com/1\""
+ " }, {"
+ " \"display_text\": \"C\","
+ " \"url\": \"http://www.example.com/2\""
+ " }, {"
+ " \"display_text\": \"D\","
+ " \"url\": \"http://www.example.com/3\""
+ " }, {"
+ " \"display_text\": \"E\","
+ " \"url\": \"http://www.example.com/4\""
+ " }, {"
+ " \"display_text\": \"F\","
+ " \"url\": \"http://www.example.com/5\""
+ " }, {"
+ " \"display_text\": \"G\","
+ " \"url\": \"http://www.example.com/6\""
+ " } ]"
+ " } ]"
+ "}",
+ {TestLegalMessageLine(
+ "aA bB cC dD eE fF gG",
+ {TestLink(1, 2, "http://www.example.com/0"),
+ TestLink(4, 5, "http://www.example.com/1"),
+ TestLink(7, 8, "http://www.example.com/2"),
+ TestLink(10, 11, "http://www.example.com/3"),
+ TestLink(13, 14, "http://www.example.com/4"),
+ TestLink(16, 17, "http://www.example.com/5"),
+ TestLink(19, 20, "http://www.example.com/6")})}}));
+
+} // namespace autofill
« components/autofill/core/browser/legal_message_line.cc ('K') | « components/autofill/core/browser/legal_message_line.cc ('k') | components/autofill/core/browser/test_autofill_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698