Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: components/autofill/core/browser/credit_card.h

Issue 1540423004: Add card details and legal message to Android save credit card infobar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix android compiles Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/credit_card.h
diff --git a/components/autofill/core/browser/credit_card.h b/components/autofill/core/browser/credit_card.h
index cb2ab21ed32858657d6570027f10f429b475c813..2cd83b85e3965faf7fd771a1207772e3aba52dd0 100644
--- a/components/autofill/core/browser/credit_card.h
+++ b/components/autofill/core/browser/credit_card.h
@@ -63,6 +63,8 @@ class CreditCard : public AutofillDataModel {
// This method is not compiled on iOS because the resources are not used and
// should not be shipped.
+// TODO(jdonnelly): Use credit card issuer images on iOS.
+// http://crbug.com/535784
#if !defined(OS_IOS)
// The ResourceBundle ID for the appropriate credit card image.
static int IconResourceId(const std::string& type);
@@ -113,6 +115,9 @@ class CreditCard : public AutofillDataModel {
// A label for this credit card formatted as 'Cardname - 2345'.
base::string16 TypeAndLastFourDigits() const;
+ // The expiration for this credit card formatted as 'Exp: 06/17'.
+ base::string16 AbbreviatedExpirationDateForDisplay() const;
Evan Stade 2016/01/13 04:09:19 given that this is only used in one place (I think
Justin Donnelly 2016/01/13 15:32:28 This will also be used on Views, Cocoa and iOS in
please use gerrit instead 2016/01/13 21:22:09 Acknowledged.
+
const std::string& type() const { return type_; }
int expiration_month() const { return expiration_month_; }

Powered by Google App Engine
This is Rietveld 408576698