components/autofill/core/browser/ui/card_unmask_prompt_controller_impl.cc - Issue 1540423004: Add card details and legal message to Android save credit card infobar.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/ui/card_unmask_prompt_controller_impl.cc

Issue 1540423004: Add card details and legal message to Android save credit card infobar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Justin's nits. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/core/browser/credit_card.h ('K') | « components/autofill/core/browser/test_autofill_client.cc ('k') | components/autofill/ios/browser/credit_card_util.mm » ('j') | components/infobars/core/infobar_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/ui/card_unmask_prompt_controller_impl.cc

diff --git a/components/autofill/core/browser/ui/card_unmask_prompt_controller_impl.cc b/components/autofill/core/browser/ui/card_unmask_prompt_controller_impl.cc

index da0fe377b4fbd91a107a809585f88cfcbee9479f..39ca8f19d11bcf020a4b71463d283e9e95e7b3ef 100644

--- a/components/autofill/core/browser/ui/card_unmask_prompt_controller_impl.cc

+++ b/components/autofill/core/browser/ui/card_unmask_prompt_controller_impl.cc

@@ -216,12 +216,13 @@ base::string16 CardUnmaskPromptControllerImpl::GetWindowTitle() const {

// The iOS UI has less room for the title and places a "Verify" button right

// next to it so the full title ("Verify your" + type and last four) is

// unnecessary.

- return card_.TypeAndLastFourDigits();

+ return card_.TypeAndLastFourDigitsForDisplay();

#else

int ids = ShouldRequestExpirationDate()

? IDS_AUTOFILL_CARD_UNMASK_PROMPT_UPDATE_TITLE

: IDS_AUTOFILL_CARD_UNMASK_PROMPT_TITLE;

- return l10n_util::GetStringFUTF16(ids, card_.TypeAndLastFourDigits());

+ return l10n_util::GetStringFUTF16(ids,

+ card_.TypeAndLastFourDigitsForDisplay());

#endif

}