Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2347)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/autofill/core/browser/legal_message_line_unittest.cc

Issue 1540423004: Add card details and legal message to Android save credit card infobar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Justin's nits. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« components/autofill/core/browser/credit_card.h ('K') | « components/autofill/core/browser/legal_message_line.cc ('k') | components/autofill/core/browser/personal_data_manager.cc » ('j') | components/infobars/core/infobar_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/core/browser/legal_message_line_unittest.cc
diff --git a/components/autofill/core/browser/legal_message_line_unittest.cc b/components/autofill/core/browser/legal_message_line_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..5fd66f733130fe024f027512b6fe5b9bf697c5ee
--- /dev/null
+++ b/components/autofill/core/browser/legal_message_line_unittest.cc
@@ -0,0 +1,358 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/autofill/core/browser/legal_message_line.h"
+
+#include <utility>
+
+#include "base/json/json_reader.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/strings/utf_string_conversions.h"
+#include "base/values.h"
+#include "testing/gmock/include/gmock/gmock.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace autofill {
+
+class LegalMessageLineTest : public ::testing::Test {
+ public:
+ LegalMessageLineTest() {}
+ ~LegalMessageLineTest() override {}
+
+ void SetLegalMessage(const std::string& message_json) {
+ scoped_ptr<base::Value> value(base::JSONReader::Read(message_json));
+ ASSERT_TRUE(value);
+ base::DictionaryValue* dictionary = nullptr;
+ ASSERT_TRUE(value->GetAsDictionary(&dictionary));
+ ASSERT_TRUE(dictionary);
+ LegalMessageLine::Parse(*dictionary, &actual_lines_);
+ }
+
+ // Returns true if lines are the same.
+ bool CompareLegalMessageLines(const LegalMessageLine& a,
+ const LegalMessageLine& b) {
+ if (a.text() != b.text())
+ return false;
+ if (a.links().size() != b.links().size())
+ return false;
+ for (size_t i = 0; i < a.links().size(); ++i) {
+ if (a.links()[i].range != b.links()[i].range)
+ return false;
+ if (a.links()[i].url != b.links()[i].url)
+ return false;
+ }
+ return true;
+ }
+
+ // Returns true if lines are the same.
+ bool CompareLegalMessages(const LegalMessageLine& single_line,
+ const LegalMessageLines& b) {
+ return b.size() == 1 && CompareLegalMessageLines(single_line, *b[0]);
+ }
+
+ // Returns true if messages are the same.
+ bool CompareLegalMessages(const LegalMessageLines& a,
+ const LegalMessageLines& b) {
+ if (a.size() != b.size())
+ return false;
+ for (size_t i = 0; i < a.size(); ++i) {
+ if (!CompareLegalMessageLines(*a[i], *b[i]))
+ return false;
+ }
+ return true;
+ }
+
+ const LegalMessageLines& actual_lines() const {
+ return actual_lines_;
+ }
+
+ private:
+ LegalMessageLines actual_lines_;
+
+ DISALLOW_COPY_AND_ASSIGN(LegalMessageLineTest);
+};
+
+TEST_F(LegalMessageLineTest, NoParameters) {
+ SetLegalMessage(
+ "{"
+ " \"line\" : [ {"
+ " \"template\": \"This is the entire message.\""
+ " } ]"
+ "}");
+
+ LegalMessageLine expected_line;
+ expected_line.text_ = base::ASCIIToUTF16("This is the entire message.");
+ EXPECT_TRUE(CompareLegalMessages(expected_line, actual_lines()));
+}
+
+TEST_F(LegalMessageLineTest, SingleParameter) {
+ SetLegalMessage(
+ "{"
+ " \"line\" : [ {"
+ " \"template\": \"Panda {0}.\","
+ " \"template_parameter\": [ {"
+ " \"display_text\": \"bears are fuzzy\","
+ " \"url\": \"http://www.example.com\""
+ " } ]"
+ " } ]"
+ "}");
+
+ LegalMessageLine expected_line;
+ expected_line.text_ = base::ASCIIToUTF16("Panda bears are fuzzy.");
+ expected_line.links_ = {
+ {{6, 21}, GURL("http://www.example.com")},
+ };
+ EXPECT_TRUE(CompareLegalMessages(expected_line, actual_lines()));
+}
+
+TEST_F(LegalMessageLineTest, MissingUrl) {
+ SetLegalMessage(
+ "{"
+ " \"line\" : [ {"
+ " \"template\": \"Panda {0}.\","
+ " \"template_parameter\": [ {"
+ " \"display_text\": \"bear\""
+ " } ]"
+ " } ]"
+ "}");
+ // Legal message is invalid so actual_lines() should return no lines.
+ EXPECT_TRUE(
+ CompareLegalMessages(LegalMessageLines(), actual_lines()));
+}
+
+TEST_F(LegalMessageLineTest, MissingDisplayText) {
+ SetLegalMessage(
+ "{"
+ " \"line\" : [ {"
+ " \"template\": \"Panda {0}.\","
+ " \"template_parameter\": [ {"
+ " \"url\": \"http://www.example.com\""
+ " } ]"
+ " } ]"
+ "}");
+ // Legal message is invalid so actual_lines() should return no lines.
+ EXPECT_TRUE(
+ CompareLegalMessages(LegalMessageLines(), actual_lines()));
+}
+
+TEST_F(LegalMessageLineTest, EscapeCharacters) {
+ SetLegalMessage(
+ "{"
+ " \"line\" : [ {"
+ " \"template\": \"Panda '{'{0}'}' '{1}' don't $1.\","
+ " \"template_parameter\": [ {"
+ " \"display_text\": \"bears\","
+ " \"url\": \"http://www.example.com\""
+ " } ]"
+ " } ]"
+ "}");
+
+ LegalMessageLine expected_line;
+ expected_line.text_ = base::ASCIIToUTF16("Panda {bears} {1} don't $1.");
+ expected_line.links_ = {
+ {{7, 12}, GURL("http://www.example.com")},
+ };
+ EXPECT_TRUE(CompareLegalMessages(expected_line, actual_lines()));
+}
+
+TEST_F(LegalMessageLineTest, ConsecutiveDollarSigns) {
+ SetLegalMessage(
+ "{"
+ " \"line\" : [ {"
+ " \"template\": \"$$\""
+ " } ]"
+ "}");
+
+ // Consecutive dollar signs do not expand correctly (see comment in
+ // ReplaceTemplatePlaceholders() in save_card_bubble_controller_impl.cc).
+ // If this is fixed and this test starts to fail, please update the
+ // "Caveats" section of the SaveCardBubbleControllerImpl::SetLegalMessage()
+ // header file comment.
+ LegalMessageLine expected_line;
+ expected_line.text_ = base::ASCIIToUTF16("$$$");
+
+ EXPECT_TRUE(CompareLegalMessages(expected_line, actual_lines()));
+}
+
+TEST_F(LegalMessageLineTest, DollarAndParenthesis) {
+ // "${" does not expand correctly (see comment in
+ // ReplaceTemplatePlaceholders() in save_card_bubble_controller_impl.cc).
+ // If this is fixed and this test starts to fail, please update the
+ // "Caveats" section of the SaveCardBubbleControllerImpl::SetLegalMessage()
+ // header file comment.
+ SetLegalMessage(
+ "{"
+ " \"line\" : [ {"
+ " \"template\": \"${0}\","
+ " \"template_parameter\": [ {"
+ " \"display_text\": \"bears\","
+ " \"url\": \"http://www.example.com\""
+ " } ]"
+ " } ]"
+ "}");
+ // Legal message is invalid so actual_lines() should return no lines.
+ EXPECT_TRUE(
+ CompareLegalMessages(LegalMessageLines(), actual_lines()));
+}
+
+TEST_F(LegalMessageLineTest, MultipleParameters) {
+ SetLegalMessage(
+ "{"
+ " \"line\" : [ {"
+ " \"template\": \"Panda {0} like {2} eat {1}.\","
+ " \"template_parameter\": [ {"
+ " \"display_text\": \"bears\","
+ " \"url\": \"http://www.example.com/0\""
+ " }, {"
+ " \"display_text\": \"bamboo\","
+ " \"url\": \"http://www.example.com/1\""
+ " }, {"
+ " \"display_text\": \"to\","
+ " \"url\": \"http://www.example.com/2\""
+ " } ]"
+ " } ]"
+ "}");
+
+ LegalMessageLine expected_line;
+ expected_line.text_ = base::ASCIIToUTF16("Panda bears like to eat bamboo.");
+ expected_line.links_ = {
+ {{6, 11}, GURL("http://www.example.com/0")},
+ {{24, 30}, GURL("http://www.example.com/1")},
+ {{17, 19}, GURL("http://www.example.com/2")},
+ };
+ EXPECT_TRUE(CompareLegalMessages(expected_line, actual_lines()));
+}
+
+TEST_F(LegalMessageLineTest, MultipleLineElements) {
+ SetLegalMessage(
+ "{"
+ " \"line\" : [ {"
+ " \"template\": \"Panda {0}\","
+ " \"template_parameter\": [ {"
+ " \"display_text\": \"bears\","
+ " \"url\": \"http://www.example.com/line_0_param_0\""
+ " } ]"
+ " }, {"
+ " \"template\": \"like {1} eat {0}.\","
+ " \"template_parameter\": [ {"
+ " \"display_text\": \"bamboo\","
+ " \"url\": \"http://www.example.com/line_1_param_0\""
+ " }, {"
+ " \"display_text\": \"to\","
+ " \"url\": \"http://www.example.com/line_1_param_1\""
+ " } ]"
+ " }, {"
+ " \"template\": \"The {0}.\","
+ " \"template_parameter\": [ {"
+ " \"display_text\": \"end\","
+ " \"url\": \"http://www.example.com/line_2_param_0\""
+ " } ]"
+ " } ]"
+ "}");
+
+ LegalMessageLines expected(3);
+
+ // Line 0.
+ expected[0].reset(new LegalMessageLine);
+ expected[0]->text_ = base::ASCIIToUTF16("Panda bears");
+ expected[0]->links_ = {
+ {{6, 11}, GURL("http://www.example.com/line_0_param_0")},
+ };
+
+ // Line 1.
+ expected[1].reset(new LegalMessageLine);
+ expected[1]->text_ = base::ASCIIToUTF16("like to eat bamboo.");
+ expected[1]->links_ = {
+ {{12, 18}, GURL("http://www.example.com/line_1_param_0")},
+ {{5, 7}, GURL("http://www.example.com/line_1_param_1")},
+ };
+
+ // Line 2.
+ expected[2].reset(new LegalMessageLine);
+ expected[2]->text_ = base::ASCIIToUTF16("The end.");
+ expected[2]->links_ = {
+ {{4, 7}, GURL("http://www.example.com/line_2_param_0")},
+ };
+
+ EXPECT_TRUE(CompareLegalMessages(expected, actual_lines()));
+}
+
+TEST_F(LegalMessageLineTest, EmbeddedNewlines) {
+ SetLegalMessage(
+ "{"
+ " \"line\" : [ {"
+ " \"template\": \"Panda {0}\nlike {2} eat {1}.\nThe {3}.\","
+ " \"template_parameter\": [ {"
+ " \"display_text\": \"bears\","
+ " \"url\": \"http://www.example.com/0\""
+ " }, {"
+ " \"display_text\": \"bamboo\","
+ " \"url\": \"http://www.example.com/1\""
+ " }, {"
+ " \"display_text\": \"to\","
+ " \"url\": \"http://www.example.com/2\""
+ " }, {"
+ " \"display_text\": \"end\","
+ " \"url\": \"http://www.example.com/3\""
+ " } ]"
+ " } ]"
+ "}");
+
+ LegalMessageLine expected_line;
+ expected_line.text_ =
+ base::ASCIIToUTF16("Panda bears\nlike to eat bamboo.\nThe end.");
+ expected_line.links_ = {
+ {{6, 11}, GURL("http://www.example.com/0")},
+ {{24, 30}, GURL("http://www.example.com/1")},
+ {{17, 19}, GURL("http://www.example.com/2")},
+ {{36, 39}, GURL("http://www.example.com/3")},
+ };
+ EXPECT_TRUE(CompareLegalMessages(expected_line, actual_lines()));
+}
+
+TEST_F(LegalMessageLineTest, MaximumPlaceholders) {
+ SetLegalMessage(
+ "{"
+ " \"line\" : [ {"
+ " \"template\": \"a{0} b{1} c{2} d{3} e{4} f{5} g{6}\","
+ " \"template_parameter\": [ {"
+ " \"display_text\": \"A\","
+ " \"url\": \"http://www.example.com/0\""
+ " }, {"
+ " \"display_text\": \"B\","
+ " \"url\": \"http://www.example.com/1\""
+ " }, {"
+ " \"display_text\": \"C\","
+ " \"url\": \"http://www.example.com/2\""
+ " }, {"
+ " \"display_text\": \"D\","
+ " \"url\": \"http://www.example.com/3\""
+ " }, {"
+ " \"display_text\": \"E\","
+ " \"url\": \"http://www.example.com/4\""
+ " }, {"
+ " \"display_text\": \"F\","
+ " \"url\": \"http://www.example.com/5\""
+ " }, {"
+ " \"display_text\": \"G\","
+ " \"url\": \"http://www.example.com/6\""
+ " } ]"
+ " } ]"
+ "}");
+
+ LegalMessageLine expected_line;
+ expected_line.text_ = base::ASCIIToUTF16("aA bB cC dD eE fF gG");
+ expected_line.links_ = {
+ {{1, 2}, GURL("http://www.example.com/0")},
+ {{4, 5}, GURL("http://www.example.com/1")},
+ {{7, 8}, GURL("http://www.example.com/2")},
+ {{10, 11}, GURL("http://www.example.com/3")},
+ {{13, 14}, GURL("http://www.example.com/4")},
+ {{16, 17}, GURL("http://www.example.com/5")},
+ {{19, 20}, GURL("http://www.example.com/6")},
+ };
+ EXPECT_TRUE(CompareLegalMessages(expected_line, actual_lines()));
+}
+
+} // namespace autofill
« components/autofill/core/browser/credit_card.h ('K') | « components/autofill/core/browser/legal_message_line.cc ('k') | components/autofill/core/browser/personal_data_manager.cc » ('j') | components/infobars/core/infobar_manager.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698