Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: components/autofill/core/browser/credit_card_unittest.cc

Issue 1540423004: Add card details and legal message to Android save credit card infobar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Justin's nits. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/credit_card_unittest.cc
diff --git a/components/autofill/core/browser/credit_card_unittest.cc b/components/autofill/core/browser/credit_card_unittest.cc
index 135d48726b79cff1518b2c20cccd01b65b02d97d..a28412664b61b3cd02fed21b5507fbdcc14fa889 100644
--- a/components/autofill/core/browser/credit_card_unittest.cc
+++ b/components/autofill/core/browser/credit_card_unittest.cc
@@ -69,7 +69,7 @@ TEST(CreditCardTest, PreviewSummaryAndTypeAndLastFourDigitsStrings) {
CreditCard credit_card0(base::GenerateGUID(), "https://www.example.com/");
base::string16 summary0 = credit_card0.Label();
EXPECT_EQ(base::string16(), summary0);
- base::string16 obfuscated0 = credit_card0.TypeAndLastFourDigits();
+ base::string16 obfuscated0 = credit_card0.TypeAndLastFourDigitsForDisplay();
EXPECT_EQ(ASCIIToUTF16("Card"), obfuscated0);
// Case 00: Empty credit card with empty strings.
@@ -77,7 +77,7 @@ TEST(CreditCardTest, PreviewSummaryAndTypeAndLastFourDigitsStrings) {
test::SetCreditCardInfo(&credit_card00,"John Dillinger", "", "", "");
base::string16 summary00 = credit_card00.Label();
EXPECT_EQ(base::string16(ASCIIToUTF16("John Dillinger")), summary00);
- base::string16 obfuscated00 = credit_card00.TypeAndLastFourDigits();
+ base::string16 obfuscated00 = credit_card00.TypeAndLastFourDigitsForDisplay();
EXPECT_EQ(ASCIIToUTF16("Card"), obfuscated00);
// Case 1: No credit card number.
@@ -85,7 +85,7 @@ TEST(CreditCardTest, PreviewSummaryAndTypeAndLastFourDigitsStrings) {
test::SetCreditCardInfo(&credit_card1,"John Dillinger", "", "01", "2010");
base::string16 summary1 = credit_card1.Label();
EXPECT_EQ(base::string16(ASCIIToUTF16("John Dillinger")), summary1);
- base::string16 obfuscated1 = credit_card1.TypeAndLastFourDigits();
+ base::string16 obfuscated1 = credit_card1.TypeAndLastFourDigitsForDisplay();
EXPECT_EQ(ASCIIToUTF16("Card"), obfuscated1);
// Case 2: No month.
@@ -97,7 +97,7 @@ TEST(CreditCardTest, PreviewSummaryAndTypeAndLastFourDigitsStrings) {
"MasterCard\xC2\xA0\xE2\x8B\xAF"
"5100"),
summary2);
- base::string16 obfuscated2 = credit_card2.TypeAndLastFourDigits();
+ base::string16 obfuscated2 = credit_card2.TypeAndLastFourDigitsForDisplay();
EXPECT_EQ(UTF8ToUTF16(
"MasterCard\xC2\xA0\xE2\x8B\xAF"
"5100"),
@@ -112,7 +112,7 @@ TEST(CreditCardTest, PreviewSummaryAndTypeAndLastFourDigitsStrings) {
"MasterCard\xC2\xA0\xE2\x8B\xAF"
"5100"),
summary3);
- base::string16 obfuscated3 = credit_card3.TypeAndLastFourDigits();
+ base::string16 obfuscated3 = credit_card3.TypeAndLastFourDigitsForDisplay();
EXPECT_EQ(UTF8ToUTF16(
"MasterCard\xC2\xA0\xE2\x8B\xAF"
"5100"),
@@ -127,7 +127,7 @@ TEST(CreditCardTest, PreviewSummaryAndTypeAndLastFourDigitsStrings) {
"MasterCard\xC2\xA0\xE2\x8B\xAF"
"5100, 01/2010"),
summary4);
- base::string16 obfuscated4 = credit_card4.TypeAndLastFourDigits();
+ base::string16 obfuscated4 = credit_card4.TypeAndLastFourDigitsForDisplay();
EXPECT_EQ(UTF8ToUTF16(
"MasterCard\xC2\xA0\xE2\x8B\xAF"
"5100"),
@@ -144,7 +144,7 @@ TEST(CreditCardTest, PreviewSummaryAndTypeAndLastFourDigitsStrings) {
"Card\xC2\xA0\xE2\x8B\xAF"
"5100, 01/2010"),
summary5);
- base::string16 obfuscated5 = credit_card5.TypeAndLastFourDigits();
+ base::string16 obfuscated5 = credit_card5.TypeAndLastFourDigitsForDisplay();
EXPECT_EQ(UTF8ToUTF16(
"Card\xC2\xA0\xE2\x8B\xAF"
"5100"),

Powered by Google App Engine
This is Rietveld 408576698