chrome/browser/autofill/android/personal_data_manager_android.cc - Issue 1540423004: Add card details and legal message to Android save credit card infobar.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autofill/android/personal_data_manager_android.cc

Issue 1540423004: Add card details and legal message to Android save credit card infobar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Justin's nits. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/chrome_jni_registrar.cc ('k') | chrome/browser/infobars/infobar_service.h » ('j') | chrome/browser/ui/android/infobars/autofill_cc_infobar.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/autofill/android/personal_data_manager_android.cc

diff --git a/chrome/browser/autofill/android/personal_data_manager_android.cc b/chrome/browser/autofill/android/personal_data_manager_android.cc

index e913975948204f437ec4b0184fd47a63ed683df2..08259807c1b332ca0b7d3ceaf0a4a99d6dd806eb 100644

--- a/chrome/browser/autofill/android/personal_data_manager_android.cc

+++ b/chrome/browser/autofill/android/personal_data_manager_android.cc

@@ -130,9 +130,10 @@ ScopedJavaLocalRef<jobject> CreateJavaCreditCardFromNative(

card.record_type() == CreditCard::FULL_SERVER_CARD,

ConvertUTF16ToJavaString(env, card.GetRawInfo(CREDIT_CARD_NAME)).obj(),

ConvertUTF16ToJavaString(env, card.GetRawInfo(CREDIT_CARD_NUMBER)).obj(),

- ConvertUTF16ToJavaString(env, card.TypeAndLastFourDigits()).obj(),

- ConvertUTF16ToJavaString(env, card.GetRawInfo(CREDIT_CARD_EXP_MONTH))

- .obj(),

+ ConvertUTF16ToJavaString(

+ env, card.TypeAndLastFourDigitsForDisplay()).obj(),

+ ConvertUTF16ToJavaString(

+ env, card.GetRawInfo(CREDIT_CARD_EXP_MONTH)).obj(),

ConvertUTF16ToJavaString(

env, card.GetRawInfo(CREDIT_CARD_EXP_4_DIGIT_YEAR)).obj());

}