Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: chrome/browser/ui/autofill/save_card_bubble_controller.h

Issue 1540423004: Add card details and legal message to Android save credit card infobar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Edits Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/save_card_bubble_controller.h
diff --git a/chrome/browser/ui/autofill/save_card_bubble_controller.h b/chrome/browser/ui/autofill/save_card_bubble_controller.h
index 231c9d08b6db0620f76ae4bc4904dae8f5916bf5..1dc3dc5f44a90b63a7ed35c1655f00f7cc2f86b2 100644
--- a/chrome/browser/ui/autofill/save_card_bubble_controller.h
+++ b/chrome/browser/ui/autofill/save_card_bubble_controller.h
@@ -8,32 +8,18 @@
#include <vector>
#include "base/macros.h"
+#include "base/memory/scoped_ptr.h"
#include "base/strings/string16.h"
-#include "ui/gfx/range/range.h"
#include "url/gurl.h"
namespace autofill {
+class LegalMessageLine;
class SaveCardBubbleView;
// Interface that exposes controller functionality to SaveCardBubbleView.
class SaveCardBubbleController {
public:
- struct LegalMessageLine {
- struct Link {
- gfx::Range range;
- GURL url;
- };
-
- LegalMessageLine();
- ~LegalMessageLine();
-
- base::string16 text;
- std::vector<Link> links;
- };
-
- typedef std::vector<LegalMessageLine> LegalMessageLines;
-
// Returns the title that should be displayed in the bubble.
virtual base::string16 GetWindowTitle() const = 0;
@@ -51,7 +37,8 @@ class SaveCardBubbleController {
// State.
// Returns empty vector if no legal message should be shown.
- virtual const LegalMessageLines& GetLegalMessageLines() const = 0;
+ virtual const std::vector<scoped_ptr<LegalMessageLine>>&
Justin Donnelly 2016/01/07 18:15:40 Why scoped_ptr? What was wrong with the vector of
please use gerrit instead 2016/01/08 00:07:05 Cannot use vector of values for LegalMessageLine,
+ GetLegalMessageLines() const = 0;
protected:
SaveCardBubbleController() {}

Powered by Google App Engine
This is Rietveld 408576698