Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1146)

Issue 1540413002: net: add a ctor to IPEndPoint that takes an IPAddress (Closed)

Created:
5 years ago by tfarina
Modified:
5 years ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

net: add a ctor to IPEndPoint that takes an IPAddress This patch adds a ctor to IPEndPoint that takes an IPAddress to easy the transition from IPAddressNumber typedef. BUG=496258 R=eroman@chromium.org Committed: https://crrev.com/0dc490e6e74639b324595015bc23b7d831e16e5d Cr-Commit-Position: refs/heads/master@{#366644}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -5 lines) Patch
M net/base/ip_endpoint.h View 2 chunks +4 lines, -0 lines 0 comments Download
M net/base/ip_endpoint.cc View 2 chunks +15 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
tfarina
Martijn, would be fine if I land this?
5 years ago (2015-12-22 13:09:31 UTC) #2
martijnc
On 2015/12/22 at 13:09:31, tfarina wrote: > Martijn, would be fine if I land this? ...
5 years ago (2015-12-22 13:51:41 UTC) #3
eroman
lgtm
5 years ago (2015-12-22 19:47:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1540413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1540413002/1
5 years ago (2015-12-22 20:03:33 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-22 20:51:53 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-22 20:52:55 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0dc490e6e74639b324595015bc23b7d831e16e5d
Cr-Commit-Position: refs/heads/master@{#366644}

Powered by Google App Engine
This is Rietveld 408576698