Issue 15404003: Revert 200954 "Revert "InstantExtended: Prevent spurious themech..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15404003: Revert 200954 "Revert "InstantExtended: Prevent spurious themech..." (Closed)

Created:
7 years, 7 months ago by Vitaly Buka (NO REVIEWS)

Modified:
7 years, 7 months ago

Reviewers:
Jered

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 200954 "Revert "InstantExtended: Prevent spurious themech..." 200954 breaks mac interactive_ui_tests:InstantExtendedTest.ReloadSearchAfterBackReloadsCorrectQuery > Revert "InstantExtended: Prevent spurious themechanged/mostvisitedchanged events" > > This reverts commit 9fa73739c47280860c0e5a44af62885bee391e12. > > BUG=238671 > > Review URL: https://chromiumcodereview.appspot.com/15297013 TBR=jered@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200966

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -0 lines)			Patch
	M	trunk/src/chrome/common/instant_types.h	View		2 chunks	+4 lines, -0 lines	0 comments	Download
	M	trunk/src/chrome/renderer/searchbox/searchbox.cc	View		3 chunks	+37 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Vitaly Buka (NO REVIEWS)

Committed patchset #1 manually as r200966.

7 years, 7 months ago (2013-05-18 08:44:34 UTC) #2

Jered

On 2013/05/18 08:44:34, Vitaly Buka wrote: > Committed patchset #1 manually as r200966. Thanks, but ...

7 years, 7 months ago (2013-05-20 16:01:57 UTC) #3

Vitaly Buka (NO REVIEWS)

7 years, 7 months ago (2013-05-20 17:55:13 UTC) #4

It's not likely. With this patch 4 or something next build failed when it
never failed before.
Also I tried on my machine with or without this patch and there was a
difference.

On Mon, May 20, 2013 at 9:01 AM, <jered@chromium.org> wrote:

> On 2013/05/18 08:44:34, Vitaly Buka wrote:
>
>> Committed patchset #1 manually as r200966.
>>
>
> Thanks, but actually this was an unrelated flake.
>
>
https://codereview.chromium.**org/15404003/<https://codereview.chromium.org/1...
>

Expand Messages | Collapse Messages