Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1540323002:
Replace NOTREACHED with VLOG in BluetoothEventRouter::AddPairingDelegateImpl (Closed)
|
Created:
5 years ago by stevenjb Modified:
4 years, 12 months ago Reviewers:
michaelpg CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionReplace NOTREACHED with VLOG in BluetoothEventRouter::AddPairingDelegateImpl
Multiple instances of the same WebUI URL can legitimately share a pairing delegate.
BUG=568426
Committed: https://crrev.com/2429595387b523ebcb83b8957cc57277c076d005
Cr-Commit-Position: refs/heads/master@{#367007}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Typo #Messages
Total messages: 18 (10 generated)
Description was changed from ========== Replace NOTREACHED with VLOG BUG=568426 ========== to ========== Replace NOTREACHED with VLOG BUG=568426 ==========
Description was changed from ========== Replace NOTREACHED with VLOG BUG=568426 ========== to ========== Replace NOTREACHED with VLOG in BluetoothEventRouter::AddPairingDelegateImpl Multiple instances of the same WebUI URL may share a pairing delegate. BUG=568426 ==========
Description was changed from ========== Replace NOTREACHED with VLOG in BluetoothEventRouter::AddPairingDelegateImpl Multiple instances of the same WebUI URL may share a pairing delegate. BUG=568426 ========== to ========== Replace NOTREACHED with VLOG in BluetoothEventRouter::AddPairingDelegateImpl Multiple instances of the same WebUI URL can legitimately share a pairing delegate. BUG=568426 ==========
stevenjb@chromium.org changed reviewers: + michaelpg@chromium.org
lgtm https://codereview.chromium.org/1540323002/diff/1/extensions/browser/api/blue... File extensions/browser/api/bluetooth/bluetooth_event_router.cc (right): https://codereview.chromium.org/1540323002/diff/1/extensions/browser/api/blue... extensions/browser/api/bluetooth/bluetooth_event_router.cc:243: LOG(ERROR) << "Unable to get adatper for extension_id: " << extension_id; adapter
https://codereview.chromium.org/1540323002/diff/1/extensions/browser/api/blue... File extensions/browser/api/bluetooth/bluetooth_event_router.cc (right): https://codereview.chromium.org/1540323002/diff/1/extensions/browser/api/blue... extensions/browser/api/bluetooth/bluetooth_event_router.cc:243: LOG(ERROR) << "Unable to get adatper for extension_id: " << extension_id; On 2015/12/22 00:49:48, michaelpg wrote: > adapter Done.
The CQ bit was checked by stevenjb@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from michaelpg@chromium.org Link to the patchset: https://codereview.chromium.org/1540323002/#ps20001 (title: "Typo")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1540323002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1540323002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by stevenjb@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1540323002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1540323002/20001
Message was sent while issue was closed.
Description was changed from ========== Replace NOTREACHED with VLOG in BluetoothEventRouter::AddPairingDelegateImpl Multiple instances of the same WebUI URL can legitimately share a pairing delegate. BUG=568426 ========== to ========== Replace NOTREACHED with VLOG in BluetoothEventRouter::AddPairingDelegateImpl Multiple instances of the same WebUI URL can legitimately share a pairing delegate. BUG=568426 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Replace NOTREACHED with VLOG in BluetoothEventRouter::AddPairingDelegateImpl Multiple instances of the same WebUI URL can legitimately share a pairing delegate. BUG=568426 ========== to ========== Replace NOTREACHED with VLOG in BluetoothEventRouter::AddPairingDelegateImpl Multiple instances of the same WebUI URL can legitimately share a pairing delegate. BUG=568426 Committed: https://crrev.com/2429595387b523ebcb83b8957cc57277c076d005 Cr-Commit-Position: refs/heads/master@{#367007} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/2429595387b523ebcb83b8957cc57277c076d005 Cr-Commit-Position: refs/heads/master@{#367007} |
