base/logging.h - Issue 15403002: Remving global statics from the headers, so we can split-link.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/logging.h

Issue 15403002: Remving global statics from the headers, so we can split-link. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/logging.h

diff --git a/base/logging.h b/base/logging.h

index 71596f09cecef6490c85abead623c192a1d718af..e04f630e981cc186312a632b3e46acae3731ea6b 100644

--- a/base/logging.h

+++ b/base/logging.h

@@ -648,7 +648,7 @@ enum { DEBUG_MODE = ENABLE_DLOG };

#if defined(NDEBUG)

-BASE_EXPORT extern DcheckState g_dcheck_state;

+DcheckState get_dcheck_state();

scottmg 2013/05/20 19:15:15 seems like a set_dcheck_state is needed too (ios)

#if defined(DCHECK_ALWAYS_ON)

@@ -665,7 +665,7 @@ const LogSeverity LOG_DCHECK = LOG_FATAL;

#define COMPACT_GOOGLE_LOG_DCHECK COMPACT_GOOGLE_LOG_ERROR_REPORT

const LogSeverity LOG_DCHECK = LOG_ERROR_REPORT;

#define DCHECK_IS_ON() \

- ((::logging::g_dcheck_state == \

+ ((::logging::get_dcheck_state() == \

::logging::ENABLE_DCHECK_FOR_NON_OFFICIAL_RELEASE_BUILDS) && \

LOG_IS_ON(DCHECK))

« no previous file with comments | « no previous file | base/logging.cc » ('j') | no next file with comments »