Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 1540293003: Support for arm64 build. (Closed)

Created:
5 years ago by cdotstout
Modified:
4 years, 11 months ago
Reviewers:
jamesr, viettrungluu, qsr
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Support for arm64 build. Needed for fnl on n6p. Change-Id: Ief00f8190087437944a937e010f2a97d668fb610 BUG= R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/0d68ff269ecf68310681f4af67a64c60a68bae2a

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M build/config/arm.gni View 1 chunk +6 lines, -2 lines 0 comments Download
M mojo/tools/mojob.py View 1 chunk +1 line, -1 line 0 comments Download
M mojo/tools/mopy/config.py View 2 chunks +2 lines, -1 line 0 comments Download
M mojo/tools/mopy/gn_unittest.py View 1 2 chunks +2 lines, -2 lines 0 comments Download
M skia/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
cdotstout
For fnl on n6p.
5 years ago (2015-12-21 23:04:34 UTC) #2
qsr
https://codereview.chromium.org/1540293003/diff/1/build/config/arm.gni File build/config/arm.gni (right): https://codereview.chromium.org/1540293003/diff/1/build/config/arm.gni#newcode10 build/config/arm.gni:10: arm_version = 8 So, this is a gn arg. ...
5 years ago (2015-12-22 08:51:29 UTC) #3
cdotstout
On 2015/12/22 08:51:29, qsr wrote: > https://codereview.chromium.org/1540293003/diff/1/build/config/arm.gni > File build/config/arm.gni (right): > > https://codereview.chromium.org/1540293003/diff/1/build/config/arm.gni#newcode10 > ...
5 years ago (2015-12-22 18:11:55 UTC) #4
qsr
On 2015/12/22 18:11:55, cdotstout wrote: > On 2015/12/22 08:51:29, qsr wrote: > > https://codereview.chromium.org/1540293003/diff/1/build/config/arm.gni > ...
5 years ago (2015-12-23 10:35:09 UTC) #5
viettrungluu
https://codereview.chromium.org/1540293003/diff/1/mojo/tools/mopy/config.py File mojo/tools/mopy/config.py (right): https://codereview.chromium.org/1540293003/diff/1/mojo/tools/mopy/config.py#newcode30 mojo/tools/mopy/config.py:30: ARCH_ARM64 = "arm64" Please add arm64 to mojo/tools/mopy/gn_unittest.py.
4 years, 12 months ago (2015-12-27 18:02:50 UTC) #6
cdotstout
4 years, 11 months ago (2015-12-29 20:40:54 UTC) #7
cdotstout
4 years, 11 months ago (2016-01-04 17:37:40 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
0d68ff269ecf68310681f4af67a64c60a68bae2a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698