include/effects/SkEmbossMaskFilter.h - Issue 1540203002: Revert of change all factories to return their base-class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/effects/SkEmbossMaskFilter.h

Issue 1540203002: Revert of change all factories to return their base-class (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/effects/SkEmbossMaskFilter.h

diff --git a/include/effects/SkEmbossMaskFilter.h b/include/effects/SkEmbossMaskFilter.h

index 72020bf3ce74663aa7e890d4899eec41146b7a47..b6bd1a164291b47b839f1c621884b8726308805f 100644

--- a/include/effects/SkEmbossMaskFilter.h

+++ b/include/effects/SkEmbossMaskFilter.h

@@ -23,7 +23,7 @@

uint8_t fSpecular; // exponent, 4.4 right now

};

- static SkMaskFilter* Create(SkScalar blurSigma, const Light& light);

+ static SkEmbossMaskFilter* Create(SkScalar blurSigma, const Light& light);

// overrides from SkMaskFilter

// This method is not exported to java.