Revert of change all factories to return their base-class

tests/DashPathEffectTest.cpp

 /*
  * Copyright 2014 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "Test.h"
 
 #include "SkDashPathEffect.h"
 #include "SkWriteBuffer.h"
 #include "SkStrokeRec.h"
 
 // crbug.com/348821 was rooted in SkDashPathEffect refusing to flatten and unflatten itself when
 // fInitialDashLength < 0 (a signal the effect is nonsense).  Here we test that it flattens.
 
 DEF_TEST(DashPathEffectTest_crbug_348821, r) {
     SkScalar intervals[] = { 1.76934361e+36f, 2.80259693e-45f };  // Values from bug.
     const int count = 2;
     SkScalar phase = SK_ScalarInfinity;  // Used to force the bad fInitialDashLength = -1 path.
-    SkAutoTUnref<SkPathEffect> dash(SkDashPathEffect::Create(intervals, count, phase));
+    SkAutoTUnref<SkDashPathEffect> dash(SkDashPathEffect::Create(intervals, count, phase));
 
     // nullptr -> refuses to work with flattening framework.
     REPORTER_ASSERT(r, dash->getFactory() != nullptr);
 
     SkWriteBuffer buffer;
     buffer.writeFlattenable(dash);
     REPORTER_ASSERT(r, buffer.bytesWritten() > 12);  // We'd write 12 if broken, >=40 if not.
 }
 
 // Test out the asPoint culling behavior.
 DEF_TEST(DashPathEffectTest_asPoints, r) {
 
     const SkScalar intervals[] = { 1.0f, 1.0f };
     const int count = 2;
-    SkAutoTUnref<SkPathEffect> dash(SkDashPathEffect::Create(intervals, count, 0.0f));
+    SkAutoTUnref<SkDashPathEffect> dash(SkDashPathEffect::Create(intervals, count, 0.0f));
 
     SkRect cull = SkRect::MakeWH(1.0f, 1.0f);
 
     const struct {
         SkPoint fPts[2];
         bool    fExpectedResult;
     } testCases[] = {
         { { { -5.0f,  0.5f }, { -4.0f,  0.5f } }, false },   // off to the left
         { { {  4.0f,  0.5f }, {  5.0f,  0.5f } }, false },   // off to the right
         { { {  0.5f,  4.0f }, {  0.5f,  5.0f } }, false },   // off the bottom
@@ skipping 33 matching lines @@
                 if (i < 2) {
                     REPORTER_ASSERT(r, actualResult == testCases[j].fExpectedResult);
                 } else {
                     // On the third pass all the lines should be outside the translated cull rect
                     REPORTER_ASSERT(r, !actualResult);
                 }
             }
         }
     }
 }