build/android/pylib/instrumentation/test_runner.py - Issue 1540053002: Document that the user has to run `adb root` to enable java asserts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/instrumentation/test_runner.py

Issue 1540053002: Document that the user has to run `adb root` to enable java asserts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/pylib/instrumentation/test_runner.py

diff --git a/build/android/pylib/instrumentation/test_runner.py b/build/android/pylib/instrumentation/test_runner.py

index 7ff1ed6bddc9ec75b9987286820988a2211cc431..aab0c12448105e250682debc66fd9dee17d26860 100644

--- a/build/android/pylib/instrumentation/test_runner.py

+++ b/build/android/pylib/instrumentation/test_runner.py

@@ -97,7 +97,7 @@ class TestRunner(base_test_runner.BaseTestRunner):

"""Sets up the test harness and device before all tests are run."""

super(TestRunner, self).SetUp()

if not self.device.HasRoot():

- logging.warning('Unable to enable java asserts for %s, non rooted device',

+ logging.warning('Unable to enable java asserts for %s; run `adb root`.',

str(self.device))

else:

if self.device.SetJavaAsserts(self.options.set_asserts):

« no previous file with comments | « no previous file | no next file » | no next file with comments »