Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1540013004: Revert of MacKeyboard: Don't generate keypress for non-printable char (Closed)

Created:
5 years ago by danakj
Modified:
5 years ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, nona+watch_chromium.org, shuchen+watch_chromium.org, James Su, vmpstr+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of MacKeyboard: Don't generate keypress for non-printable char (patchset #8 id:140001 of https://codereview.chromium.org/1458203003/ ) Reason for revert: Needs a rebase. Breaks compile. Original issue's description: > MacKeyboard: Don't generate keypress for non-printable char > > ---Before CL: > Press Delete: > Linux: keypress (charCode=127) > Windows, Mac: no keypress > > Press Ctrl+Delete: (or Fn+Ctrl+Delete on Mac) > Mac: keypress (charCode=0xF728) > Windows, Linux: no keypress > > Press Ctrl+F12: > Mac: keypress (charCode=0xF70F) > Window, Linux: no keypress > > ---After CL: > no keypress for everyone > > BUG=459089 > > Committed: https://crrev.com/0cb4bd70989a22ea2e31590f291c0b2cc7d27433 > Cr-Commit-Position: refs/heads/master@{#366205} TBR=aelias@chromium.org,ccameron@chromium.org,dtapuska@chromium.org,erikchen@chromium.org,chongz@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=459089 Committed: https://crrev.com/904c14bf25a6e48cd787526315e1b22995d890f4 Cr-Commit-Position: refs/heads/master@{#366220}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -83 lines) Patch
M content/browser/renderer_host/input/web_input_event_builders_mac.mm View 2 chunks +10 lines, -20 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac_unittest.mm View 2 chunks +0 lines, -62 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
danakj
Created Revert of MacKeyboard: Don't generate keypress for non-printable char
5 years ago (2015-12-18 23:48:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1540013004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1540013004/1
5 years ago (2015-12-18 23:49:23 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-18 23:53:08 UTC) #3
commit-bot: I haz the power
5 years ago (2015-12-18 23:54:33 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/904c14bf25a6e48cd787526315e1b22995d890f4
Cr-Commit-Position: refs/heads/master@{#366220}

Powered by Google App Engine
This is Rietveld 408576698