Convert enable_mpeg2ts into a new-style buildflag

media/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
+import("//build/buildflag_header.gni")
 import("//build/config/android/config.gni")
 import("//build/config/arm.gni")
 import("//build/config/features.gni")
 import("//build/config/linux/pkg_config.gni")
 import("//build/config/ui.gni")
 import("//media/media_options.gni")
 import("//testing/test.gni")
 
+buildflag_header("media_features") {
+  header = "media_features.h"
+
+  # Enables the MPEG2-TS stream parser for use with Media Source. Disabled by

[ddorwin, 2016/01/04 22:19:45]

This is consistent with the previous name but now more explicit. Are there no
plans to support .src=HEVC?

[servolk, 2016/01/05 00:18:09]

Did you mean .src=foo.ts (mpeg2ts)? AFAIK there's no short-term plans to support
that, since almost all Chromecast apps use MPL player that works through MSE.

[ddorwin, 2016/01/05 18:59:56]

Yes, oops. SG.

+  # default (except on Chromecast) since it's not available on the normal Web

[ddorwin, 2016/01/04 22:19:45]

Just keep it simple: Only supported on Chromecast.
Or just drop it since we can read the line below.

[servolk, 2016/01/05 00:18:09]

Done.

+  # Platform and costs money.
+  enable_mse_mpeg2ts_stream_parser = is_chromecast
+
+  flags =
+      [ "ENABLE_MSE_MPEG2TS_STREAM_PARSER=$enable_mse_mpeg2ts_stream_parser" ]
+}
+
 # Common configuration for targets in the media directory.
 # NOT for exporting.
 config("media_config") {
   defines = []
   if (!media_use_libvpx) {
     defines += [ "MEDIA_DISABLE_LIBVPX" ]
   }
   if (!media_use_ffmpeg) {
     defines += [ "MEDIA_DISABLE_FFMPEG" ]
   }
@@ skipping 449 matching lines @@
       "mfuuid.lib",
     ]
   }
 
   if (proprietary_codecs) {
     sources += [
       "cdm/cenc_utils.cc",
       "cdm/cenc_utils.h",
       "filters/h264_to_annex_b_bitstream_converter.cc",
       "filters/h264_to_annex_b_bitstream_converter.h",
       "formats/mp2t/es_adapter_video.cc",

[ddorwin, 2016/01/04 22:19:45]

Shouldn't all of these files be protected by enable_mse_mpeg2ts_stream_parser?
That's not specifically related to this CL, but I was surprised that no source
files were protected by enable_mse_mpeg2ts_stream_parser.

[servolk, 2016/01/05 00:18:09]

Good point, I'm also a bit surprised. This code was added a while ago by
damienv@ and reviewed by acolwell@
(https://chromiumcodereview.appspot.com/23566013) both are gone from Chromium.
In this CL I've just tried to convert the build flags by mechanically replacing
strings. I'll look into guarding formats/mp2t by the new build flag/define.

       "formats/mp2t/es_adapter_video.h",
       "formats/mp2t/es_parser.cc",
       "formats/mp2t/es_parser.h",
       "formats/mp2t/es_parser_adts.cc",
       "formats/mp2t/es_parser_adts.h",
       "formats/mp2t/es_parser_h264.cc",
       "formats/mp2t/es_parser_h264.h",
       "formats/mp2t/es_parser_mpeg1audio.cc",
       "formats/mp2t/es_parser_mpeg1audio.h",
       "formats/mp2t/mp2t_common.h",
@@ skipping 49 matching lines @@
       "filters/source_buffer_platform_lowmem.cc",
     ]
   } else {
     sources += [
       "filters/source_buffer_platform.cc",
       "filters/source_buffer_platform.h",
     ]
   }
 
   public_deps = [
+    ":media_features",
     "//media/audio",
     "//media/base",
     "//third_party/opus",
   ]
 
   deps += [
     ":shared_memory_support",
     "//base",
     "//base:i18n",
     "//base/third_party/dynamic_annotations",
@@ skipping 338 matching lines @@
       "//media/base:test_support",
       "//media/test:pipeline_integration_tests",
       "//testing/gmock",
       "//testing/gtest",
       "//third_party/ffmpeg",
       "//ui/gfx:test_support",
       "//ui/gfx/geometry",
     ]
   }
 }