Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Unified Diff: net/quic/quic_framer.cc

Issue 153993015: Use an alternative fix for OneShotVisitor of CryptoFramer that doesn't (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/crypto/crypto_framer.cc ('k') | net/quic/quic_framer_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_framer.cc
diff --git a/net/quic/quic_framer.cc b/net/quic/quic_framer.cc
index 594cad924ce3c5fc684bba5d663e973db616457f..7ed8b5901a070fba470dc89ae3c2a7451b2881b5 100644
--- a/net/quic/quic_framer.cc
+++ b/net/quic/quic_framer.cc
@@ -648,9 +648,9 @@ bool QuicFramer::ProcessPublicResetPacket(
const QuicPacketPublicHeader& public_header) {
QuicPublicResetPacket packet(public_header);
- if (reader_->BytesRemaining() <=
- kPublicResetNonceSize + PACKET_6BYTE_SEQUENCE_NUMBER) {
- // An old-style public reset packet.
+ if (public_header.sequence_number_length == PACKET_6BYTE_SEQUENCE_NUMBER) {
+ // An old-style public reset packet has the
+ // PACKET_PUBLIC_FLAGS_6BYTE_SEQUENCE bits set in the public flags.
// TODO(wtc): remove this when we drop support for QUIC_VERSION_13.
if (!reader_->ReadUInt64(&packet.nonce_proof)) {
set_detailed_error("Unable to read nonce proof.");
« no previous file with comments | « net/quic/crypto/crypto_framer.cc ('k') | net/quic/quic_framer_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698