Issue 153993015: Use an alternative fix for OneShotVisitor of CryptoFramer that doesn't

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 153993015: Use an alternative fix for OneShotVisitor of CryptoFramer that doesn't (Closed)

Created:
6 years, 10 months ago by ramant (doing other things)

Modified:
6 years, 10 months ago

Reviewers:
wtc, Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Use an alternative fix for OneShotVisitor of CryptoFramer that doesn't require a done() method. Detect an old-style Public Reset packet by checking for a sequence number length of 6 in public flags. This requires updating the expected error details messages in PublicResetPacket unit tests. Merge internal change: 61152017 R=rch@chromium.org

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+53 lines, -47 lines)			Patch
M	net/quic/crypto/crypto_framer.cc	View	2 chunks	+7 lines, -14 lines	0 comments	Download
M	net/quic/quic_framer.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	net/quic/quic_framer_test.cc	View	4 chunks	+43 lines, -30 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

LGTM. Thanks!

Expand Messages | Collapse Messages