sync/internal_api/public/sessions/commit_counters.cc - Issue 1539843002: Convert Pass()→std::move() in sync/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/public/sessions/commit_counters.cc

Issue 1539843002: Convert Pass()→std::move() in sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sync/internal_api/public/sessions/commit_counters.cc

diff --git a/sync/internal_api/public/sessions/commit_counters.cc b/sync/internal_api/public/sessions/commit_counters.cc

index 6038ad29d9e62f3f7066765207ffe5f2a862a7f6..b44b54e55b04d5b420eb2317638af4e5bfe47720 100644

--- a/sync/internal_api/public/sessions/commit_counters.cc

+++ b/sync/internal_api/public/sessions/commit_counters.cc

@@ -23,7 +23,7 @@ scoped_ptr<base::DictionaryValue> CommitCounters::ToValue() const {

value->SetInteger("numCommitsSuccess", num_commits_success);

value->SetInteger("numCommitsConflict", num_commits_conflict);

value->SetInteger("numCommitsError", num_commits_error);

- return value.Pass();

+ return value;

}

std::string CommitCounters::ToString() const {