Convert Pass()→std::move() in sync/

Convert Pass()→std::move() in //sync

BUG=557422
Committed: https://crrev.com/c80b1b61bf666dfc15b6f93e8c6701cb30dc9354
Cr-Commit-Position: refs/heads/master@{#366886}

[dcheng, 2015-12-18 08:36:58]

dcheng@chromium.org changed reviewers:
+ zea@chromium.org

[dcheng, 2015-12-18 08:37:12]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-18 08:38:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1539843002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1539843002/1

[dcheng, 2015-12-18 09:19:08]

Description was changed from

==========
Convert Pass()→std::move() in sync/

BUG=557422
==========

to

==========
Convert Pass()→std::move() in //sync

BUG=557422
==========

[commit-bot: I haz the power, 2015-12-18 10:26:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-18 10:26:18]

Dry run: This issue passed the CQ dry run.

[Nicolas Zea, 2015-12-18 23:46:55]

LGTM modulo the header file issue. In certain places we've decided to keep the
header file in a public/ folder and the implementation/tests in a non-public
folder (for DEPS reasons). I'd like to preserve that convention, while still
having the header file easily discoverable at the top of an implementation file.

https://codereview.chromium.org/1539843002/diff/1/sync/internal_api/attachmen...
File sync/internal_api/attachments/attachment_downloader_impl.cc (right):

https://codereview.chromium.org/1539843002/diff/1/sync/internal_api/attachmen...
sync/internal_api/attachments/attachment_downloader_impl.cc:22: #include
"sync/internal_api/public/attachments/attachment_uploader_impl.h"
This should remain up top

https://codereview.chromium.org/1539843002/diff/1/sync/internal_api/attachmen...
File sync/internal_api/attachments/attachment_service_impl.cc (right):

https://codereview.chromium.org/1539843002/diff/1/sync/internal_api/attachmen...
sync/internal_api/attachments/attachment_service_impl.cc:13: #include
"sync/internal_api/public/attachments/attachment_service_impl.h"
Keep up top

https://codereview.chromium.org/1539843002/diff/1/sync/internal_api/attachmen...
File sync/internal_api/attachments/attachment_service_proxy_for_test.cc (right):

https://codereview.chromium.org/1539843002/diff/1/sync/internal_api/attachmen...
sync/internal_api/attachments/attachment_service_proxy_for_test.cc:10: #include
"sync/internal_api/public/attachments/attachment_service_proxy_for_test.h"
keep up top

https://codereview.chromium.org/1539843002/diff/1/sync/internal_api/attachmen...
File sync/internal_api/attachments/attachment_store_frontend.cc (right):

https://codereview.chromium.org/1539843002/diff/1/sync/internal_api/attachmen...
sync/internal_api/attachments/attachment_store_frontend.cc:12: #include
"sync/internal_api/public/attachments/attachment_store_frontend.h"
keep up top

https://codereview.chromium.org/1539843002/diff/1/sync/internal_api/attachmen...
File sync/internal_api/attachments/attachment_store_frontend_unittest.cc
(right):

https://codereview.chromium.org/1539843002/diff/1/sync/internal_api/attachmen...
sync/internal_api/attachments/attachment_store_frontend_unittest.cc:17: #include
"sync/internal_api/public/attachments/attachment_store_frontend.h"
keep up top

https://codereview.chromium.org/1539843002/diff/1/sync/internal_api/attachmen...
File sync/internal_api/attachments/attachment_uploader_impl.cc (right):

https://codereview.chromium.org/1539843002/diff/1/sync/internal_api/attachmen...
sync/internal_api/attachments/attachment_uploader_impl.cc:27: #include
"sync/internal_api/public/attachments/attachment_uploader_impl.h"
keep up top

https://codereview.chromium.org/1539843002/diff/1/sync/internal_api/attachmen...
File sync/internal_api/attachments/attachment_uploader_impl_unittest.cc (right):

https://codereview.chromium.org/1539843002/diff/1/sync/internal_api/attachmen...
sync/internal_api/attachments/attachment_uploader_impl_unittest.cc:31: #include
"sync/internal_api/public/attachments/attachment_uploader_impl.h"
keep up top

https://codereview.chromium.org/1539843002/diff/1/sync/internal_api/attachmen...
File sync/internal_api/attachments/on_disk_attachment_store.cc (right):

https://codereview.chromium.org/1539843002/diff/1/sync/internal_api/attachmen...
sync/internal_api/attachments/on_disk_attachment_store.cc:16: #include
"sync/internal_api/public/attachments/on_disk_attachment_store.h"
keep up top

https://codereview.chromium.org/1539843002/diff/1/sync/internal_api/attachmen...
File sync/internal_api/attachments/on_disk_attachment_store_unittest.cc (right):

https://codereview.chromium.org/1539843002/diff/1/sync/internal_api/attachmen...
sync/internal_api/attachments/on_disk_attachment_store_unittest.cc:17: #include
"sync/internal_api/public/attachments/on_disk_attachment_store.h"
keep up top

https://codereview.chromium.org/1539843002/diff/1/sync/internal_api/attachmen...
File sync/internal_api/attachments/task_queue_unittest.cc (right):

https://codereview.chromium.org/1539843002/diff/1/sync/internal_api/attachmen...
sync/internal_api/attachments/task_queue_unittest.cc:13: #include
"sync/internal_api/public/attachments/task_queue.h"
keep up top

https://codereview.chromium.org/1539843002/diff/1/sync/internal_api/model_typ...
File sync/internal_api/model_type_entity_unittest.cc (right):

https://codereview.chromium.org/1539843002/diff/1/sync/internal_api/model_typ...
sync/internal_api/model_type_entity_unittest.cc:10: #include
"sync/internal_api/public/model_type_entity.h"
keep up top

https://codereview.chromium.org/1539843002/diff/1/sync/internal_api/model_typ...
File sync/internal_api/model_type_store_backend.cc (right):

https://codereview.chromium.org/1539843002/diff/1/sync/internal_api/model_typ...
sync/internal_api/model_type_store_backend.cc:8: #include
"sync/internal_api/public/model_type_store_backend.h"
keep up top

https://codereview.chromium.org/1539843002/diff/1/sync/internal_api/model_typ...
File sync/internal_api/model_type_store_backend_unittest.cc (right):

https://codereview.chromium.org/1539843002/diff/1/sync/internal_api/model_typ...
sync/internal_api/model_type_store_backend_unittest.cc:10: #include
"sync/internal_api/public/model_type_store_backend.h"
keep up top

https://codereview.chromium.org/1539843002/diff/1/sync/internal_api/model_typ...
File sync/internal_api/model_type_store_impl.cc (right):

https://codereview.chromium.org/1539843002/diff/1/sync/internal_api/model_typ...
sync/internal_api/model_type_store_impl.cc:14: #include
"sync/internal_api/public/model_type_store_impl.h"
keep up top

https://codereview.chromium.org/1539843002/diff/1/sync/internal_api/model_typ...
File sync/internal_api/model_type_store_impl_unittest.cc (right):

https://codereview.chromium.org/1539843002/diff/1/sync/internal_api/model_typ...
sync/internal_api/model_type_store_impl_unittest.cc:10: #include
"sync/internal_api/public/model_type_store_impl.h"
keep up top

[dcheng, 2015-12-20 00:27:53]

https://codereview.chromium.org/1539843002/diff/1/sync/internal_api/attachmen...
File sync/internal_api/attachments/attachment_downloader_impl.cc (right):

https://codereview.chromium.org/1539843002/diff/1/sync/internal_api/attachmen...
sync/internal_api/attachments/attachment_downloader_impl.cc:22: #include
"sync/internal_api/public/attachments/attachment_uploader_impl.h"
On 2015/12/18 at 23:46:54, Nicolas Zea wrote:
> This should remain up top

Hmm. I have a script that does this all automatically. Let me think about how to
adapt it for this specific use case (since it'll be useful in //content as well)

[dcheng, 2015-12-26 01:48:02]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2015-12-26 01:48:02]

OK, the headers script has been fixed and checking the results, it appears to
better match how a human would format it. Thanks for pointing this out!

[dcheng, 2015-12-26 01:48:02]

The patchset sent to the CQ was uploaded after l-g-t-m from zea@chromium.org
Link to the patchset: https://codereview.chromium.org/1539843002/#ps20001
(title: "Cleaned up")

[commit-bot: I haz the power, 2015-12-26 01:48:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1539843002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1539843002/20001

[commit-bot: I haz the power, 2015-12-26 02:40:31]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-26 02:41:42]

Description was changed from

==========
Convert Pass()→std::move() in //sync

BUG=557422
==========

to

==========
Convert Pass()→std::move() in //sync

BUG=557422

Committed: https://crrev.com/c80b1b61bf666dfc15b6f93e8c6701cb30dc9354
Cr-Commit-Position: refs/heads/master@{#366886}
==========

[commit-bot: I haz the power, 2015-12-26 02:41:43]

Patchset 2 (id:??) landed as
https://crrev.com/c80b1b61bf666dfc15b6f93e8c6701cb30dc9354
Cr-Commit-Position: refs/heads/master@{#366886}