implement fast ReturnValue setters

implement fast ReturnValue setters

R=svenpanne@chromium.org
BUG=

Committed: https://code.google.com/p/v8/source/detail?r=14738

[Sven Panne, 2013-05-21 14:14:56]

https://chromiumcodereview.appspot.com/15398008/diff/1/include/v8.h
File include/v8.h (right):

https://chromiumcodereview.appspot.com/15398008/diff/1/include/v8.h#newcode5145
include/v8.h:5145: V8_INLINE(internal::Object* IntToSmi(int value)) {
I think returning internal::Smi* (here and below) might be more handy and would
avoid some casts later. Or is there a reason why we can't do this?

https://chromiumcodereview.appspot.com/15398008/diff/1/include/v8.h#newcode5658
include/v8.h:5658: void ReturnValue<T>::Set(Isolate* isolate, float i) {
Why do we need this function if we convert to double, anyway?

https://chromiumcodereview.appspot.com/15398008/diff/1/src/objects-inl.h
File src/objects-inl.h (right):

https://chromiumcodereview.appspot.com/15398008/diff/1/src/objects-inl.h#newc...
src/objects-inl.h:1112: bool in_range = (value >= kMinValue) && (value <=
kMaxValue);
Not from your CL, but anyway: Can we inline this and use an ASSERT_EQ?

[dcarney, 2013-05-21 15:14:44]

https://chromiumcodereview.appspot.com/15398008/diff/1/include/v8.h
File include/v8.h (right):

https://chromiumcodereview.appspot.com/15398008/diff/1/include/v8.h#newcode5145
include/v8.h:5145: V8_INLINE(internal::Object* IntToSmi(int value)) {
On 2013/05/21 14:14:56, Sven Panne wrote:
> I think returning internal::Smi* (here and below) might be more handy and
would
> avoid some casts later. Or is there a reason why we can't do this?

it makes casting in v8.h much worse, since we can't know that Smi inherits from
Object here

https://chromiumcodereview.appspot.com/15398008/diff/1/include/v8.h#newcode5658
include/v8.h:5658: void ReturnValue<T>::Set(Isolate* isolate, float i) {
On 2013/05/21 14:14:56, Sven Panne wrote:
> Why do we need this function if we convert to double, anyway?

removed

https://chromiumcodereview.appspot.com/15398008/diff/1/src/objects-inl.h
File src/objects-inl.h (right):

https://chromiumcodereview.appspot.com/15398008/diff/1/src/objects-inl.h#newc...
src/objects-inl.h:1112: bool in_range = (value >= kMinValue) && (value <=
kMaxValue);
On 2013/05/21 14:14:56, Sven Panne wrote:
> Not from your CL, but anyway: Can we inline this and use an ASSERT_EQ?

okay

[Sven Panne, 2013-05-22 06:12:24]

lgtm

[dcarney, 2013-05-22 06:35:47]

Committed patchset #3 manually as r14738 (presubmit successful).