Source/core/svg/SVGTests.cpp - Issue 15398006: SVGTests should lazyAttach

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGTests.cpp

Issue 15398006: SVGTests should lazyAttach (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: rebase Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/svg/SVGTests.cpp

diff --git a/Source/core/svg/SVGTests.cpp b/Source/core/svg/SVGTests.cpp

index 41b64a2174258587f6a5366b027f58ccaaf8fe3b..fda18cfbee180dbb8c49533aed58127867c6fcef 100644

--- a/Source/core/svg/SVGTests.cpp

+++ b/Source/core/svg/SVGTests.cpp

@@ -156,10 +156,9 @@ bool SVGTests::handleAttributeChange(SVGElement* targetElement, const QualifiedN

return true;

bool valid = targetElement->isValid();

- bool attached = targetElement->attached();

- if (valid && !attached && targetElement->parentNode()->attached())

- targetElement->attach();

- else if (!valid && attached)

+ if (valid && !targetElement->attached() && targetElement->parentNode()->attached())

+ targetElement->lazyAttach();

+ else if (!valid && targetElement->attached())

targetElement->detach();

return true;

« no previous file with comments | « no previous file | no next file » | no next file with comments »