SVGTests should lazyAttach

Source/core/svg/SVGTests.cpp

 /*
  * Copyright (C) 2004, 2005, 2008 Nikolas Zimmermann <zimmermann@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007 Rob Buis <buis@kde.org>
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
@@ skipping 139 matching lines @@
 
 bool SVGTests::handleAttributeChange(SVGElement* targetElement, const QualifiedName& attrName)
 {
     ASSERT(targetElement);
     if (!isKnownAttribute(attrName))
         return false;
     if (!targetElement->inDocument())
         return true;
 
     bool valid = targetElement->isValid();
-    bool attached = targetElement->attached();
-    if (valid && !attached && targetElement->parentNode()->attached())
-        targetElement->attach();
-    else if (!valid && attached)
+    if (valid && !targetElement->attached())

[pdr., 2013/05/18 03:37:59]

You removed the parentNode check here which was added in
http://trac.webkit.org/changeset/126657 to fix a security bug. Can you help me
understand why that's safe?

+        targetElement->lazyAttach();
+    else if (!valid && targetElement->attached())
         targetElement->detach();
 
     return true;
 }
 
 void SVGTests::addSupportedAttributes(HashSet<QualifiedName>& supportedAttributes)
 {
     supportedAttributes.add(SVGNames::requiredFeaturesAttr);
     supportedAttributes.add(SVGNames::requiredExtensionsAttr);
     supportedAttributes.add(SVGNames::systemLanguageAttr);
@@ skipping 40 matching lines @@
 
 SVGStringList& SVGTests::systemLanguage()
 {
     m_systemLanguage.shouldSynchronize = true;
     return m_systemLanguage.value;
 }
 
 }
 
 #endif // ENABLE(SVG)