Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: chrome/browser/android/data_usage/data_use_ui_tab_model.h

Issue 1539763004: Miscellaneous fixes to DataUse UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/data_usage/data_use_ui_tab_model.h
diff --git a/chrome/browser/android/data_usage/data_use_ui_tab_model.h b/chrome/browser/android/data_usage/data_use_ui_tab_model.h
index f4d6db0d23e6096e44df70bf3d053ea2763fd7ab..80eb99c9d11f55de1ab05ce04464a89db0c7da95 100644
--- a/chrome/browser/android/data_usage/data_use_ui_tab_model.h
+++ b/chrome/browser/android/data_usage/data_use_ui_tab_model.h
@@ -64,8 +64,8 @@ class DataUseUITabModel : public KeyedService,
// Reports a custom tab navigation to the DataUseTabModel on the IO thread.
// Includes the |tab_id|, |url|, and |package_name| for the navigation.
void ReportCustomTabInitialNavigation(SessionID::id_type tab_id,
- const std::string& url,
- const std::string& package_name);
+ const std::string& package_name,
+ const std::string& url);
// Returns true if data use tracking has been started for the tab with id
// |tab_id|. Calling this function resets the state of the tab.
@@ -75,6 +75,17 @@ class DataUseUITabModel : public KeyedService,
// Calling this function resets the state of the tab.
bool HasDataUseTrackingEnded(SessionID::id_type tab_id);
+ // Returns true if the tab with id |tab_id| is currently tracked, and
+ // starting the navigation to |url| with transition type |page_transition|
+ // would end tracking of data use.
+ bool WouldDataUseTrackingEnd(const std::string& url,
+ int page_transition,
+ SessionID::id_type tab_id) const;
+
+ // Notifies that user clicked "Continue" when the dialog box with data use
+ // warning was shown. Includes the |tab_id| on which the warning was shown.
+ void UserClickedContinueOnDialogBox(SessionID::id_type tab_id);
+
// Sets the weak pointer to DataUseTabModel.
void SetDataUseTabModel(base::WeakPtr<DataUseTabModel> data_use_tab_model);
@@ -92,6 +103,9 @@ class DataUseUITabModel : public KeyedService,
// Indicates that data use tracking has ended.
DATA_USE_TRACKING_ENDED,
+
+ // Indicates that user clicked "Continue" when the dialog box was shown.
+ DATA_USE_CONTINUE_CLICKED,
};
typedef base::hash_map<SessionID::id_type, DataUseTrackingEvent> TabEvents;

Powered by Google App Engine
This is Rietveld 408576698