chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java - Issue 1539763004: Miscellaneous fixes to DataUse UI

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

Issue 1539763004: Miscellaneous fixes to DataUse UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/datausage/DataUseTabUIManager.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/datausage/DataUseTabUIManager.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

index 9e0d6bcbb052703100b12290e05255718cbceb74..33f14da77160ca2242efae3f405c3998f4a4db92 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

@@ -468,7 +468,7 @@ public abstract class ChromeActivity extends AsyncInitializationActivity

if (mTabModelSelectorTabObserver != null) mTabModelSelectorTabObserver.destroy();

mTabModelSelectorTabObserver = new TabModelSelectorTabObserver(tabModelSelector) {

@Override

- public void onPageLoadStarted(Tab tab, String url) {

+ public void didFirstVisuallyNonEmptyPaint(Tab tab) {

megjablon 2015/12/18 20:17:53 Do we know if waiting for the first paint is ok wi

tbansal1 2015/12/18 21:35:37 I assume so. It is similar to Lo-Fi. On slow netwo

megjablon 2015/12/18 22:08:10 Acknowledged.

if (DataUseTabUIManager.checkDataUseTrackingStarted(tab)) {

mDataUseSnackbarController.showDataUseTrackingStartedBar();

} else if (DataUseTabUIManager.checkDataUseTrackingEnded(tab)

megjablon 2015/12/18 20:17:53 The getOptedOutOfDataUseDialog check should come b

tbansal1 2015/12/18 21:35:37 Good point. Done.

@@ -476,10 +476,7 @@ public abstract class ChromeActivity extends AsyncInitializationActivity

.getOptedOutOfDataUseDialog(getApplicationContext())) {

mDataUseSnackbarController.showDataUseTrackingEndedBar();

}

- }

- @Override

- public void didFirstVisuallyNonEmptyPaint(Tab tab) {

if (!tab.isNativePage() && !tab.isIncognito()

&& DataReductionProxySettings.getInstance().wasLoFiModeActiveOnMainFrame()

&& DataReductionProxySettings.getInstance().canUseDataReductionProxy(